Mt 1892 handle oauth errors - #1
Open
gerard-mailtrack wants to merge 4 commits into
Open
gerard-mailtrack wants to merge 4 commits into
gerard-mailtrack wants to merge 4 commits into
Conversation
| try { | ||
| $authorizationUrl = $this->container->get('hwi_oauth.security.oauth_utils')->getAuthorizationUrl($request, $service); | ||
| } catch (\RuntimeException $e) { | ||
| throw new NotFoundHttpException($e->getMessage(), $e); |
Author
There was a problem hiding this comment.
Fixes issue: Invalid Resource owner errors do not throw CRITICAL error
Exception was not caught. We just rethrow as 404.
| $this->httpClient->send($request, $response); | ||
| } catch (ClientException $e) { | ||
| throw new HttpTransportException('Error while sending HTTP request', $this->getName(), $e->getCode(), $e); | ||
| // Do nothing: user will be redirected to failure_path |
Author
There was a problem hiding this comment.
Fixes issue: Google API errors generate CRITICAL error.
We just keep going on without useful user, and the error happens later and is handled appropriately.
| $extraParameters = array_merge($extraParameters, $extraSessionParameters); | ||
| $session->remove($sessionKey); | ||
| } | ||
|
|
Author
There was a problem hiding this comment.
Fixes issue: Missing refresh tokens after signin up with permissions granted.
This allows to perform an auth retry with additional options, after an error is detected.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Created just for easier review.