Skip to content

fix: module issue assignment #245

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pablohashescobar merged 4 commits into from
Feb 7, 2023
Merged

fix: module issue assignment #245

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f09c9b6
fix: module issue assignment
pablohashescobar Feb 7, 2023
8801a29
fix: module issue updation and activity logging
pablohashescobar Feb 7, 2023
51b3815
fix: typo while creating module issues
pablohashescobar Feb 7, 2023
1d44071
fix: string comparison for update operation
pablohashescobar Feb 7, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions apiserver/plane/api/views/module.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -161,14 +161,14 @@ def create(self, request, slug, project_id, module_id):
module_issue = [
module_issue
for module_issue in module_issues
if module_issue.issue_id in issues
if str(module_issue.issue_id) in issues
]

if len(module_issue):
if module_issue[0].cycle_id != module_id:
if module_issue[0].module_id != module_id:
update_module_issue_activity.append(
{
"old_module_id": str(module_issue[0].cycle_id),
"old_module_id": str(module_issue[0].module_id),
"new_module_id": str(module_id),
"issue_id": str(module_issue[0].issue_id),
}
Expand All @@ -179,7 +179,7 @@ def create(self, request, slug, project_id, module_id):
record_to_create.append(
ModuleIssue(
module=module,
issue=issue,
issue_id=issue,
project_id=project_id,
workspace=module.workspace,
created_by=request.user,
Expand All @@ -203,14 +203,14 @@ def create(self, request, slug, project_id, module_id):
issue_activity.delay(
{
"type": "issue.activity",
"requested_data": json.dumps({"cycles_list": issues}),
"requested_data": json.dumps({"modules_list": issues}),
"actor_id": str(self.request.user.id),
"issue_id": str(self.kwargs.get("pk", None)),
"project_id": str(self.kwargs.get("project_id", None)),
"current_instance": json.dumps(
{
"updated_cycle_issues": update_module_issue_activity,
"created_cycle_issues": serializers.serialize(
"updated_module_issues": update_module_issue_activity,
"created_module_issues": serializers.serialize(
"json", record_to_create
),
}
Expand Down