fix: custom theme validation added - #3246
Merged
Merged
Conversation
sriramveeraghanta
approved these changes
Dec 26, 2023
vamsikrishnamathala
pushed a commit
that referenced
this pull request
Aug 7, 2025
- No need to nack for messages as retry is not implemented. - Ack for all messages, this should remove dual ack errors
DoctorFogarty
pushed a commit
to DoctorFogarty/plane
that referenced
this pull request
Aug 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem:
New users encounter an application error when they attempt to switch to a custom theme. To reproduce this issue:
Resolution:
The problem occurs from a recent code refactoring, causing the removal of necessary default values. I've rectified this by implementing a validation: if no palette is available, the theme won't be applied.
These issues are associated with [PLE-154]