fix: onboarding redirection loop and bug fixes - #3250
Merged
Conversation
| // if next_path is provided, redirect the user to that url | ||
| if (next_path) { | ||
| if (isValidURL(next_path.toString())) { | ||
| router.push(next_path.toString()); |
Check warning
Code scanning / CodeQL
Client-side URL redirect
| else handleUserRouteAuthentication(); | ||
| if (next_path) { | ||
| if (isValidURL(next_path.toString())) { | ||
| router.push(next_path.toString()); |
Check warning
Code scanning / CodeQL
Client-side URL redirect
| // if next_path is provided, redirect the user to that url | ||
| if (next_path) { | ||
| if (isValidURL(next_path.toString())) { | ||
| router.push(next_path.toString()); |
Check failure
Code scanning / CodeQL
Client-side cross-site scripting
| else handleUserRouteAuthentication(); | ||
| if (next_path) { | ||
| if (isValidURL(next_path.toString())) { | ||
| router.push(next_path.toString()); |
Check failure
Code scanning / CodeQL
Client-side cross-site scripting
sriramveeraghanta
pushed a commit
that referenced
this pull request
Jan 22, 2024
* chore: try and catch added in handleSignInRedirection * chore: remove unnecessary hooks * fix: handleCopyIssueLink url updated * chore: swap next_url with next_path and validate redirection logic for next_path url
vamsikrishnamathala
pushed a commit
that referenced
this pull request
Aug 7, 2025
DoctorFogarty
pushed a commit
to DoctorFogarty/plane
that referenced
this pull request
Aug 7, 2026
* chore: try and catch added in handleSignInRedirection * chore: remove unnecessary hooks * fix: handleCopyIssueLink url updated * chore: swap next_url with next_path and validate redirection logic for next_path url
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem:
Resolution:
These issues are associated with following: