Skip to content

Chore/user role validation - #3260

Merged
sriramveeraghanta merged 9 commits into
developfrom
chore/user-role-validation
Dec 29, 2023
Merged

Chore/user role validation#3260
sriramveeraghanta merged 9 commits into
developfrom
chore/user-role-validation

Conversation

@prateekshourya29

@prateekshourya29 prateekshourya29 commented Dec 27, 2023

Copy link
Copy Markdown
Member

Problem

  1. Guests and Viewers could access the 'Save View' button, causing errors due to restricted access.
  2. Guests and Viewers could access Date and Label properties even without access.

Solution

  1. Removed Save View option from the header for Guest/ Viewers.

Before Fix

image

After Fix

image

  1. Disabled Date and Label properties with proper styling for all views.
    https://github.com/makeplane/plane/assets/33979846/461ab417-db26-4ef6-add3-63517e92d8d3

@prateekshourya29 prateekshourya29 changed the title Chore/user role validation Chore/user role validation and add/ remove filter refactor Dec 27, 2023
@prateekshourya29
prateekshourya29 marked this pull request as ready for review December 28, 2023 08:53
@prateekshourya29 prateekshourya29 changed the title Chore/user role validation and add/ remove filter refactor Chore/user role validation Dec 28, 2023
Comment thread web/components/issues/issue-layouts/kanban/properties.tsx Outdated
@sriramveeraghanta
sriramveeraghanta merged commit f132fe5 into develop Dec 29, 2023
@sriramveeraghanta
sriramveeraghanta deleted the chore/user-role-validation branch December 29, 2023 11:05
sriramveeraghanta pushed a commit that referenced this pull request Jan 22, 2024
* chore: remove `Save View` option for guest/ viewer from project issues header.

* chore: allow guest/ viewer to clear applied filters in project issues.

* chore: disable `date`, `label` property access for guests/ viewer in all project issue views.

* chore: update `Workspace Issues` -> `All Issues` header.

* chore: refactor apply/ clear filter implementation in All Issues.

* Revert "chore: refactor apply/ clear filter implementation in All Issues."

This reverts commit 024822d.

* Revert "chore: allow guest/ viewer to clear applied filters in project issues."

This reverts commit 3dae871.

* Revert "chore: update `Workspace Issues` -> `All Issues` header."

This reverts commit 03f90be.

* chore: remove `cursor-pointer` style from non actionable issue properties.
vamsikrishnamathala pushed a commit that referenced this pull request Aug 7, 2025
* chore: endpoints for advance analytics

* chore: updated the analytics version

* chore: added query paramter for tables

* chore: updated the analytics stats

* chore: added updated at and updated by

* chore: analytics endpoints ee

* chore: revamped the analytics

* chore: removed the duplicated code

* fix: minor value update

* chore: added the filter to remove bot users

* chore: added the is bot validation for project memebers
DoctorFogarty pushed a commit to DoctorFogarty/plane that referenced this pull request Aug 7, 2026
* chore: remove `Save View` option for guest/ viewer from project issues header.

* chore: allow guest/ viewer to clear applied filters in project issues.

* chore: disable `date`, `label` property access for guests/ viewer in all project issue views.

* chore: update `Workspace Issues` -> `All Issues` header.

* chore: refactor apply/ clear filter implementation in All Issues.

* Revert "chore: refactor apply/ clear filter implementation in All Issues."

This reverts commit 024822d.

* Revert "chore: allow guest/ viewer to clear applied filters in project issues."

This reverts commit 3dae871.

* Revert "chore: update `Workspace Issues` -> `All Issues` header."

This reverts commit 03f90be.

* chore: remove `cursor-pointer` style from non actionable issue properties.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants