Skip to content

[WEB-1833] fix: editor bold text color - #5197

Merged
SatishGandham merged 1 commit into
previewfrom
fix/editor-bold
Jul 23, 2024
Merged

[WEB-1833] fix: editor bold text color#5197
SatishGandham merged 1 commit into
previewfrom
fix/editor-bold

Conversation

@aaryan610

@aaryan610 aaryan610 commented Jul 22, 2024

Copy link
Copy Markdown
Member

Problem:

When making a table content bold when background color is applied to the row/column, the text color changes to invert mode making it impossible to read.

Solution:

Updated the bold text color from primary text to inherit the parent's text color.

Media:

Before After
Screen.Recording.2024-07-22.at.19.33.50.mov
Screen.Recording.2024-07-22.at.19.28.52.mov

Plane issue: WEB-1833

Summary by CodeRabbit

  • New Features

    • Enhanced styling flexibility for bold text in prose elements by allowing it to inherit color from its parent, improving design consistency.
  • Bug Fixes

    • Resolved styling inconsistency by updating the bold text color property in Tailwind CSS configuration.

@aaryan610 aaryan610 added this to the v0.23-dev milestone Jul 22, 2024
@aaryan610
aaryan610 requested a review from SatishGandham July 22, 2024 14:05
@coderabbitai

coderabbitai Bot commented Jul 22, 2024

Copy link
Copy Markdown
Contributor

Walkthrough

The recent update to the Tailwind CSS configuration enhances the handling of bold text within prose elements. By changing the --tw-prose-bold property from a specific color value to "inherit", bold text will now dynamically adopt the color of its parent element. This modification allows for improved flexibility in styling, enabling a more context-sensitive approach to text color within the design.

Changes

File Change Summary
packages/tailwind-config-custom/tailwind.config.js Updated --tw-prose-bold property from RGB value to "inherit" for improved color flexibility in bold text.

Poem

馃悋 In a garden where colors blend,
The bold text now has a new friend.
It dances with hues from its kin,
"Inherit!" it shouts, let the styling begin!
A whimsical change, so bright and true,
A tale of colors, in prose anew! 馃尲


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 0839666 and a46524b.

Files selected for processing (1)
  • packages/tailwind-config-custom/tailwind.config.js (1 hunks)
Additional comments not posted (1)
packages/tailwind-config-custom/tailwind.config.js (1)

273-273: LGTM! Update to --tw-prose-bold property improves readability.

The change to set --tw-prose-bold to "inherit" ensures that bold text inherits its color from the parent element, which enhances readability, especially in tables with colored backgrounds.

@SatishGandham
SatishGandham merged commit 7b6a234 into preview Jul 23, 2024
@SatishGandham
SatishGandham deleted the fix/editor-bold branch July 23, 2024 07:52
DoctorFogarty pushed a commit to DoctorFogarty/plane that referenced this pull request Aug 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants