Skip to content

refactor: navigation design enhancements #8309

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
anmolsinghbhatia merged 1 commit into from
Dec 11, 2025
Merged

refactor: navigation design enhancements #8309

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions apps/web/core/components/navigation/top-nav-power-k.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -209,15 +209,15 @@ export const TopNavPowerK = observer(() => {
>
<div
className={cn(
"flex items-center w-full h-7 p-2 rounded-lg bg-layer-1-active hover:bg-layer-1-hover border border-transparent transition-colors duration-200",
"flex items-center w-full h-7 p-2 rounded-lg bg-layer-2 border border-subtle-1 transition-colors duration-200",
{
"border-subtle": isOpen,
"bg-layer-1": isOpen,
}
)}
onClick={() => inputRef.current?.focus()}
role="button"
>
<SearchIcon className="shrink-0 size-3.5 text-tertiary mr-2" />
<SearchIcon className="shrink-0 size-3.5 text-placeholder mr-2" />
<input
ref={inputRef}
type="text"
Expand All @@ -230,7 +230,7 @@ export const TopNavPowerK = observer(() => {
onFocus={handleFocus}
onKeyDown={handleKeyDown}
placeholder="Search commands..."
className="flex-1 bg-transparent text-13 text-primary placeholder-custom-text-350 outline-none min-w-0"
className="flex-1 bg-transparent text-13 text-primary placeholder-text-placeholder outline-none min-w-0"
/>
{searchTerm && (
<button type="button" onClick={handleClear} className="shrink-0 ml-2">
Expand Down
2 changes: 1 addition & 1 deletion ...re/components/workspace/sidebar/favorites/favorite-items/common/favorite-item-wrapper.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ export function FavoriteItemWrapper(props: Props) {
<div
ref={elementRef}
className={cn(
"group/project-item cursor-pointer relative group flex items-center justify-between w-full gap-1.5 rounded-sm px-2 py-1 outline-none text-secondary hover:bg-surface-2 active:bg-surface-2",
"group/project-item relative w-full px-2 py-1.5 flex items-center rounded-md text-primary hover:bg-layer-transparent-hover",
{
"bg-surface-2": isMenuActive,
}
Expand Down
2 changes: 1 addition & 1 deletion apps/web/core/components/workspace/sidebar/favorites/favorite-items/root.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,7 +120,7 @@ export const FavoriteRoot = observer(function FavoriteRoot(props: Props) {

return (
<>
<DropIndicator isVisible={instruction === "reorder-above"} />
{isDragging && <DropIndicator isVisible={instruction === "reorder-above"} />}
<FavoriteItemWrapper elementRef={elementRef} isMenuActive={isMenuActive}>
<FavoriteItemDragHandle isDragging={isDragging} sort_order={favorite.sort_order} />
<FavoriteItemTitle href={itemLink} icon={itemIcon} title={itemTitle} />
Expand Down
6 changes: 3 additions & 3 deletions apps/web/core/components/workspace/sidebar/favorites/favorites-menu.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -178,7 +178,7 @@ export const SidebarFavoritesMenu = observer(function SidebarFavoritesMenu() {
<div
ref={elementRef}
className={cn(
"group/favorites-button w-full flex items-center justify-between px-2 py-1.5 rounded-sm text-placeholder hover:bg-surface-2"
"group/favorites-button w-full flex items-center justify-between px-2 py-1.5 rounded-sm text-placeholder hover:bg-layer-transparent-hover"
)}
>
<Disclosure.Button
Expand All @@ -203,7 +203,7 @@ export const SidebarFavoritesMenu = observer(function SidebarFavoritesMenu() {
<Tooltip tooltipHeading={t("create_folder")} tooltipContent="">
<button
type="button"
className="p-0.5 rounded-sm hover:bg-layer-1 flex-shrink-0 grid place-items-center"
className="p-0.5 rounded-sm hover:bg-layer-transparent-hover flex-shrink-0 grid place-items-center"
onClick={() => {
setCreateNewFolder(true);
if (!isFavoriteMenuOpen) toggleFavoriteMenu(!isFavoriteMenuOpen);
Expand All @@ -216,7 +216,7 @@ export const SidebarFavoritesMenu = observer(function SidebarFavoritesMenu() {
<Disclosure.Button
as="button"
type="button"
className="p-0.5 rounded-sm hover:bg-layer-1 flex-shrink-0 grid place-items-center"
className="p-0.5 rounded-sm hover:bg-layer-transparent-hover flex-shrink-0 grid place-items-center"
onClick={() => toggleFavoriteMenu(!isFavoriteMenuOpen)}
aria-label={t(
isFavoriteMenuOpen
Expand Down