-
Notifications
You must be signed in to change notification settings - Fork 5.3k
[WEB-5614] chore: platform design token enhancements #8373
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -3,12 +3,12 @@ import React from "react"; | |
| import { observer } from "mobx-react"; | ||
| import Link from "next/link"; | ||
| import { useParams } from "next/navigation"; | ||
| import { Check, Hotel, Users } from "lucide-react"; | ||
| import { Check, Hotel } from "lucide-react"; | ||
| // plane ui | ||
| import { EUserPermissions, EUserPermissionsLevel, PROJECT_TRACKER_ELEMENTS } from "@plane/constants"; | ||
| import { useLocalStorage } from "@plane/hooks"; | ||
| import { useTranslation } from "@plane/i18n"; | ||
| import { ProjectIcon, CloseIcon } from "@plane/propel/icons"; | ||
| import { MembersPropertyIcon, ProjectIcon, CloseIcon } from "@plane/propel/icons"; | ||
| import { cn, getFileURL } from "@plane/utils"; | ||
| // helpers | ||
| // hooks | ||
|
|
@@ -66,7 +66,7 @@ export const NoProjectsEmptyState = observer(function NoProjectsEmptyState() { | |
| id: "invite-team", | ||
| title: "home.empty.invite_team.title", | ||
| description: "home.empty.invite_team.description", | ||
| icon: <Users className="size-4" />, | ||
| icon: <MembersPropertyIcon className="size-4" />, | ||
| flag: "visited_members", | ||
| cta: { | ||
| text: "home.empty.invite_team.cta", | ||
|
|
@@ -103,7 +103,7 @@ export const NoProjectsEmptyState = observer(function NoProjectsEmptyState() { | |
| </Link> | ||
| ) : ( | ||
| <Link href={`/${workspaceSlug}/profile/${currentUser?.id}`}> | ||
| <span className="relative flex size-4 items-center justify-center rounded-full bg-gray-700 p-4 capitalize text-on-color text-13"> | ||
| <span className="relative flex size-4 items-center justify-center rounded-full bg-[#028375] p-4 capitalize text-on-color text-13"> | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Replace hardcoded hex color with a design token. Using Consider defining this teal color as a semantic design token (e.g., 🔎 Suggested approachIf a design token for this color exists, use it: -<span className="relative flex size-4 items-center justify-center rounded-full bg-[#028375] p-4 capitalize text-on-color text-13">
+<span className="relative flex size-4 items-center justify-center rounded-full bg-avatar-placeholder p-4 capitalize text-on-color text-13">If no token exists, add one to your design system configuration first, then reference it.
|
||
| {(currentUser?.email ?? currentUser?.display_name ?? "?")[0]} | ||
| </span> | ||
| </Link> | ||
|
|
@@ -150,7 +150,7 @@ export const NoProjectsEmptyState = observer(function NoProjectsEmptyState() { | |
| {EMPTY_STATE_DATA.map((item) => { | ||
| const isStateComplete = isComplete(item.flag); | ||
| return ( | ||
| <div key={item.id} className="flex flex-col p-4 bg-surface-1 rounded-xl border border-subtle/40"> | ||
| <div key={item.id} className="flex flex-col p-4 bg-layer-2 rounded-xl border border-subtle"> | ||
| <div | ||
| className={cn("grid place-items-center bg-surface-2 rounded-full size-9 mb-3 text-placeholder", { | ||
| "text-accent-primary bg-accent-primary/10": !isStateComplete, | ||
|
|
@@ -187,7 +187,7 @@ export const NoProjectsEmptyState = observer(function NoProjectsEmptyState() { | |
| ) : ( | ||
| <button | ||
| type="button" | ||
| className="text-accent-primary hover:text-accent-secondary text-13 font-medium" | ||
| className="text-accent-primary hover:text-accent-secondary text-13 font-medium text-left" | ||
| onClick={item.cta.onClick} | ||
| > | ||
| {t(item.cta.text)} | ||
|
|
||
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
| @@ -1,19 +1,19 @@ | ||||||
| "use client"; | ||||||
|
|
||||||
| import { observer } from "mobx-react"; | ||||||
| import { TOAST_TYPE, setToast } from "@plane/propel/toast"; | ||||||
| import type { TContextMenuItem } from "@plane/ui"; | ||||||
| import { CustomMenu } from "@plane/ui"; | ||||||
| import { copyUrlToClipboard, cn } from "@plane/utils"; | ||||||
| import { useLayoutMenuItems } from "@/components/common/quick-actions-helper"; | ||||||
| import { Ellipsis, MoreHorizontal } from "lucide-react"; | ||||||
|
||||||
| import { Ellipsis, MoreHorizontal } from "lucide-react"; | |
| import { Ellipsis } from "lucide-react"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hardcoded color value instead of design token. The background color is using a hardcoded hex value "#028375" instead of a Tailwind CSS color class or design token. This is inconsistent with the PR's purpose of enhancing platform design tokens. Consider using a semantic color token like "bg-accent-primary" or another appropriate token from the design system.