fix: add missing model_activity.delay() for API-driven issue webhooks by ouchanip · Pull Request #8792 · makeplane/plane

ouchanip · 2026-03-24T17:12:36Z

Summary

Fixes #6746 — Webhooks are not triggered when issues are created or updated via the API.

Problem

The put() (update and create-via-upsert) and partial_update() methods in apps/api/plane/api/views/issue.py only call issue_activity.delay() but not model_activity.delay(). Since model_activity is what triggers webhook_activity → webhook_send_task in the Celery worker, webhooks are never dispatched for API-driven issue changes.

The web UI code paths (e.g. post() at L475) already include model_activity.delay(), so this is only missing from the API views.

Fix

Added model_activity.delay() immediately after each existing issue_activity.delay() in three locations:

PUT update — existing issue update via external_id
PUT create-via-upsert — new issue creation via external_id
PATCH — partial issue update

Uses the same function signature as the existing model_activity.delay() call in post().

Testing

Tested on Plane CE v1.2.1 (self-hosted, Docker):

Applied patch via bind mount to API container
Sent PATCH request via API to update issue priority
Confirmed Celery worker logs show:
- model_activity task received
- webhook_activity task received
- webhook_send_task sent successfully

Before the fix, none of these tasks were triggered for API-driven updates.

Summary by CodeRabbit

Chores
- Improved webhook event dispatching for issue operations to enhance activity tracking across create, update, and patch workflows, enabling better integration support and data synchronization.

…webhook dispatch Fixes #6746 API-driven issue updates (PUT update, PUT create-via-upsert, PATCH) were missing `model_activity.delay()` calls, so webhooks were never dispatched for changes made through the API. The web UI paths already include these calls (e.g. in `post()` at L475), but the `put()` and `partial_update()` methods only called `issue_activity.delay()`. This adds `model_activity.delay()` immediately after each existing `issue_activity.delay()` in these three code paths, using the same signature as the existing call in `post()`. Tested on Plane CE v1.2.1 self-hosted: API PATCH triggers `webhook_send_task` in the Celery worker, confirming webhook delivery. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

CLAassistant · 2026-03-24T17:12:44Z

All committers have signed the CLA.

coderabbitai · 2026-03-24T17:12:56Z

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 6e1a0146-1f52-4ad8-98ea-463dfa106bda

📥 Commits

Reviewing files that changed from the base of the PR and between 9d3b5d9 and 74a5ab9.

📒 Files selected for processing (1)

apps/api/plane/api/views/issue.py

📝 Walkthrough

Walkthrough

Added webhook dispatch calls to the issue detail API endpoint's PUT and PATCH methods. The changes ensure that whenever issues are created or updated via the API, corresponding model_activity.delay() calls are triggered to notify external webhook subscribers of these events.

Changes

Cohort / File(s)	Summary
Issue API Webhook Dispatch `apps/api/plane/api/views/issue.py`	Added `model_activity.delay()` calls in `IssueDetailAPIEndpoint.put` (for both update and create-new scenarios) and `IssueDetailAPIEndpoint.patch` to trigger webhook events with appropriate model identifiers and actor information after issue operations complete.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

🐰 Bouncing with joy through the API,
Webhooks now trigger when tasks we do see,
PUT and PATCH now dispatch with delight,
External systems receive the news right!
No more silent updates, the messages fly—
Integration complete, as we hop on by! ✨

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly and concisely describes the main change: adding missing model_activity.delay() calls for API-driven issue webhooks.
Description check	✅ Passed	The PR description is comprehensive, including problem statement, solution, and testing verification. However, it lacks the structured template sections like 'Type of Change' checkboxes and 'Test Scenarios' as defined in the repository template.
Linked Issues check	✅ Passed	The PR directly addresses issue `#6746` by adding model_activity.delay() calls to the API issue view methods, ensuring webhooks are triggered for API-driven create/update operations.
Out of Scope Changes check	✅ Passed	All changes are within scope: modifications only affect the issue API view methods to add missing webhook dispatch calls, directly addressing the linked issue requirement.
Docstring Coverage	✅ Passed	Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

Copilot

Pull request overview

Adds the missing model_activity.delay() calls to the issue API update/upsert code paths so Celery can trigger webhook dispatch for API-driven issue changes (matching the existing web UI behavior).

Changes:

Trigger model_activity.delay() after issue updates in PUT (existing issue via external_id).
Trigger model_activity.delay() after issue creation in PUT upsert flow (new issue via external_id).
Trigger model_activity.delay() after PATCH partial updates.

Copilot · 2026-03-24T17:17:19Z

+                    # Send the model activity for webhook dispatch
+                    model_activity.delay(
+                        model_name="issue",
+                        model_id=str(issue.id),
+                        requested_data=request.data,
+                        current_instance=current_instance,
+                        actor_id=request.user.id,
+                        slug=slug,
+                        origin=base_host(request=request, is_app=True),
+                    )


Consider adding an automated regression test that asserts model_activity.delay() is triggered for issue PUT/PATCH API updates (in addition to issue_activity.delay()), since this PR fixes webhook dispatching via model_activity and it’s easy to accidentally regress in future refactors. A lightweight approach is to patch plane.bgtasks.webhook_task.model_activity.delay (or Celery Task.delay) and verify it’s called on update and create-via-upsert paths.

Copilot AI review requested due to automatic review settings March 24, 2026 17:12

Copilot started reviewing on behalf of ouchanip March 24, 2026 17:13 View session

Copilot AI reviewed Mar 24, 2026

View reviewed changes

ouchanip mentioned this pull request Mar 24, 2026

test: add regression test for model_activity.delay() in API issue views #8793

Closed

sriramveeraghanta requested a review from NarayanBavisetti March 24, 2026 18:45

NarayanBavisetti approved these changes Mar 24, 2026

View reviewed changes

sriramveeraghanta merged commit d94a269 into makeplane:preview Mar 25, 2026
5 of 6 checks passed

prue-starfield mentioned this pull request Mar 31, 2026

feat: allow private/loopback webhook URLs for self-hosted instances #8837

Closed

Navigation Menu

Uh oh!

fix: add missing model_activity.delay() for API-driven issue webhooks - #8792

fix: add missing model_activity.delay() for API-driven issue webhooks#8792
sriramveeraghanta merged 1 commit into
makeplane:previewfrom
ouchanip:fix/api-webhook-model-activity

ouchanip commented Mar 24, 2026 •

edited by coderabbitai Bot

Loading

Uh oh!

CLAassistant commented Mar 24, 2026 •

edited

Loading

Uh oh!

coderabbitai Bot commented Mar 24, 2026 •

edited

Loading

Walkthrough

Changes

Estimated code review effort

Poem

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Mar 24, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Uh oh!

Conversation

ouchanip commented Mar 24, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Problem

Fix

Testing

Summary by CodeRabbit

Uh oh!

CLAassistant commented Mar 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

coderabbitai Bot commented Mar 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Estimated code review effort

Poem

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI Mar 24, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

ouchanip commented Mar 24, 2026 •

edited by coderabbitai Bot

Loading

CLAassistant commented Mar 24, 2026 •

edited

Loading

coderabbitai Bot commented Mar 24, 2026 •

edited

Loading