Skip to content

chore: remove service token endpoint which is unused - #8797

Merged
sriramveeraghanta merged 1 commit into
previewfrom
fix-unused-service-token-endpoint
Mar 25, 2026
Merged

chore: remove service token endpoint which is unused#8797
sriramveeraghanta merged 1 commit into
previewfrom
fix-unused-service-token-endpoint

Conversation

@sriramveeraghanta

@sriramveeraghanta sriramveeraghanta commented Mar 25, 2026

Copy link
Copy Markdown
Member

Description

  • remove unsed Endpoint

Type of Change

- [ ] Code refactoring

Summary by CodeRabbit

  • Refactor
    • Removed service API tokens endpoint at the workspace level. User-level API tokens remain available for authentication and integration purposes.

Copilot AI review requested due to automatic review settings March 25, 2026 07:39
@coderabbitai

coderabbitai Bot commented Mar 25, 2026

Copy link
Copy Markdown
Contributor

Caution

Review failed

Pull request was closed or merged during review

📝 Walkthrough

Walkthrough

The changes remove service-level API token functionality by deleting the ServiceApiTokenEndpoint class and its associated route, while retaining the ApiTokenEndpoint for user-scoped API tokens. Three files are affected with a total of approximately 3 lines added and 34 removed.

Changes

Cohort / File(s) Summary
Service API Token Removal
apps/api/plane/app/urls/api.py, apps/api/plane/app/views/__init__.py, apps/api/plane/app/views/api.py
Removed ServiceApiTokenEndpoint class and its route (workspaces/<str:slug>/service-api-tokens/). Deleted workspace-scoped token creation logic, removed endpoint from public exports, and eliminated associated imports (Workspace, WorkspaceEntityPermission). The ApiTokenEndpoint for user-scoped tokens remains unchanged.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

A service token bids farewell today, 🐰
Three files cleaned up in the rabbit's way,
No more workspace scopes to create and bind,
User tokens only—simpler by design!

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Description check ❓ Inconclusive The description is minimal and contains a typo ('unsed' instead of 'unused'). While it identifies the change, it lacks detail about what was removed, why, and impact assessment. Expand the description to explain what the ServiceApiTokenEndpoint was, why it's unused, and confirm no breaking changes. Fix the typo 'unsed' to 'unused'.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title 'chore: remove service token endpoint which is unused' accurately summarizes the main change—removal of an unused ServiceApiTokenEndpoint class across three files.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix-unused-service-token-endpoint

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR removes an unused “service API token” endpoint from the API surface, along with its view export and URL route, reducing dead code in the API layer.

Changes:

  • Deleted ServiceApiTokenEndpoint from apps/api/plane/app/views/api.py and removed now-unneeded imports.
  • Removed the corresponding view export from apps/api/plane/app/views/__init__.py.
  • Removed the "workspaces/<str:slug>/service-api-tokens/" URL pattern from apps/api/plane/app/urls/api.py.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
apps/api/plane/app/views/api.py Removes the unused service-token endpoint implementation and related imports.
apps/api/plane/app/views/init.py Stops exporting the removed endpoint from the views package.
apps/api/plane/app/urls/api.py Removes the URL route and import for the removed endpoint.

@sriramveeraghanta
sriramveeraghanta merged commit f3c7c05 into preview Mar 25, 2026
15 of 17 checks passed
@sriramveeraghanta
sriramveeraghanta deleted the fix-unused-service-token-endpoint branch March 25, 2026 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants