Skip to content

fix: pnpm path for Docker builds - #9079

Merged
sriramveeraghanta merged 1 commit into
canaryfrom
fix/pnpm/path/ci
May 14, 2026
Merged

fix: pnpm path for Docker builds#9079
sriramveeraghanta merged 1 commit into
canaryfrom
fix/pnpm/path/ci

Conversation

@sriramveeraghanta

@sriramveeraghanta sriramveeraghanta commented May 14, 2026

Copy link
Copy Markdown
Member

Summary

  • Add $PNPM_HOME/bin to PATH in community Dockerfiles so corepack-installed pnpm binaries are resolvable during Docker builds.

Files updated:

  • apps/admin/Dockerfile.admin
  • apps/live/Dockerfile.live
  • apps/space/Dockerfile.space
  • apps/web/Dockerfile.web

Change: ENV PATH="$PNPM_HOME:$PATH"ENV PATH="$PNPM_HOME:$PNPM_HOME/bin:$PATH"

Test plan

  • Docker builds succeed for admin, live, space, and web images on CI

Add $PNPM_HOME/bin to PATH so corepack-installed pnpm binaries are
resolvable during Docker builds.
Copilot AI review requested due to automatic review settings May 14, 2026 19:32
@coderabbitai

coderabbitai Bot commented May 14, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 32a926e8-3a2d-499b-963f-1f2828e40ef5

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/pnpm/path/ci

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds $PNPM_HOME/bin to the PATH in the four community Dockerfiles so that corepack-installed pnpm binaries are resolvable during Docker builds, mirroring the enterprise fix in makeplane/plane-ee#7150.

Changes:

  • Update PATH in admin, live, space, and web Dockerfiles to include $PNPM_HOME/bin.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File Description
apps/admin/Dockerfile.admin Append $PNPM_HOME/bin to PATH for corepack pnpm resolution.
apps/live/Dockerfile.live Append $PNPM_HOME/bin to PATH for corepack pnpm resolution.
apps/space/Dockerfile.space Append $PNPM_HOME/bin to PATH for corepack pnpm resolution.
apps/web/Dockerfile.web Append $PNPM_HOME/bin to PATH for corepack pnpm resolution.

@sriramveeraghanta
sriramveeraghanta merged commit 1dabc63 into canary May 14, 2026
6 checks passed
@sriramveeraghanta
sriramveeraghanta deleted the fix/pnpm/path/ci branch May 14, 2026 19:35
MagicRB pushed a commit to MagicRB/plane that referenced this pull request Jun 17, 2026
Add $PNPM_HOME/bin to PATH so corepack-installed pnpm binaries are
resolvable during Docker builds.
manhhn01 pushed a commit to manhhn01/planex that referenced this pull request Jul 20, 2026
…lane#47)

Upstream fixed this in Dockerfile.admin/web/space/live via makeplane#9079 but our
custom Dockerfile.iw-* variants weren't included in that merge. Same fix:
  ENV PATH="\$PNPM_HOME:\$PNPM_HOME/bin:\$PATH"
Without /bin, corepack-installed pnpm binaries aren't resolvable and
pnpm add -g turbo fails with "global bin directory not in PATH".

Co-authored-by: Surya <surya@eyriehq.com>
(cherry picked from commit 468f4f5)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants