-
Notifications
You must be signed in to change notification settings - Fork 5.3k
chore: restructure .claude/skills into per-skill directories #9146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,67 @@ | ||
| --- | ||
| name: branch-name | ||
| description: Use when starting a new branch or renaming an existing one — produces a branch name in the format `<type>/<work-item-id>-<short-description>` that's compatible with the create-pr skill's work item ID extraction. | ||
| user_invocable: true | ||
| --- | ||
|
|
||
| # Branch Naming | ||
|
|
||
| Create branch names that follow the convention `<type>/<work-item-id>-<short-description>`, where the work item ID can be cleanly extracted later (e.g., by the create-pr skill). | ||
|
|
||
| ## Format | ||
|
|
||
| ``` | ||
| <type>/<work-item-id>-<short-description> | ||
| ``` | ||
|
Comment on lines
+13
to
+15
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Add language identifiers to fenced code blocks. These fences are missing language tags, which triggers markdownlint and reduces tooling support. Proposed fix-```
+```text
<type>/<work-item-id>-<short-description>- Verify each finding against current code. Fix only still-valid issues, skip the In @.claude/skills/branch-name/SKILL.md around lines 13 - 15, Update the fenced |
||
|
|
||
| - All lowercase, hyphen-separated | ||
| - Work item ID stays in its original form but lowercased (e.g., `SILO-1146` → `silo-1146`) | ||
| - Short description is 2–5 words in kebab-case, focused on the _what_, not the _how_ | ||
|
|
||
| ## Workflow | ||
|
|
||
| 1. **Determine the type** based on the work being done: | ||
| - `feat` — new functionality | ||
| - `fix` — bug fix | ||
| - `chore` — tooling, deps, config, non-user-facing housekeeping | ||
| - `refactor` — restructuring without behavior change | ||
| - `docs` — documentation only | ||
| - `perf` — performance improvement | ||
|
|
||
| 2. **Determine the work item ID**: | ||
| - If the user gives one, use it | ||
| - If they reference a Plane work item (e.g., a URL or title), extract the ID | ||
| - If none exists, ask the user — don't invent one | ||
|
|
||
| 3. **Write the short description**: | ||
| - 2–5 words in kebab-case | ||
| - Describe the outcome, not the implementation (`add-app-tile-visibility`, not `update-tile-component`) | ||
| - Skip filler words (`the`, `a`, `for`) | ||
|
|
||
| 4. **Assemble and create the branch**: | ||
|
|
||
| ``` | ||
| git checkout -b <type>/<work-item-id-lowercased>-<short-description> | ||
| ``` | ||
|
|
||
| 5. **Return the branch name** to the user. | ||
|
|
||
| ## Examples | ||
|
|
||
| ``` | ||
| fix/silo-1146-relative-config-urls | ||
| feat/web-1234-app-tile-visibility | ||
| chore/web-2201-bump-eslint | ||
| refactor/silo-980-extract-auth-middleware | ||
| docs/web-1500-pr-template-update | ||
| perf/silo-1310-cache-workspace-lookup | ||
| ``` | ||
|
|
||
| ## Common Mistakes | ||
|
|
||
| - Putting the work item ID at the end instead of after the type (breaks extraction) | ||
| - Using underscores or camelCase instead of hyphens | ||
| - Uppercasing the work item ID inside the branch name (it should be lowercase here, uppercased only when used as the PR title prefix) | ||
| - Writing a long, narrative description — keep it scannable | ||
| - Omitting the work item ID when one exists in Plane | ||
| - Using a type that won't match the eventual PR type (pick the type you'd use in the PR title) | ||
| Original file line number | Diff line number | Diff line change | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|
| @@ -0,0 +1,65 @@ | ||||||||||||
| --- | ||||||||||||
| name: create-pull-request | ||||||||||||
| description: Use when creating a pull request for the current branch — gathers branch context, generates a PR description following the repo's pull_request_template.md, and creates the PR with a Plane work item ID prefix in the title. | ||||||||||||
| user_invocable: true | ||||||||||||
| --- | ||||||||||||
|
|
||||||||||||
| # Create PR | ||||||||||||
|
|
||||||||||||
| Create a pull request using the repo's PR template, a Plane work item ID as the title prefix, and a fully filled-out description based on the actual diff. | ||||||||||||
|
|
||||||||||||
| ## Workflow | ||||||||||||
|
|
||||||||||||
| 1. **Determine the base branch**: Default to `preview` unless the user specifies otherwise. | ||||||||||||
|
|
||||||||||||
| 2. **Gather context** (in parallel): | ||||||||||||
| - `git status -s` — check for uncommitted changes | ||||||||||||
| - `git diff <base>...HEAD --stat` — files changed | ||||||||||||
| - `git log <base>...HEAD --oneline` — all commits on the branch | ||||||||||||
| - `git diff <base>...HEAD --no-color` — full diff for understanding changes (if very large, focus on the most important files first) | ||||||||||||
| - `git rev-parse --abbrev-ref --symbolic-full-name @{u}` — check if branch tracks a remote | ||||||||||||
| - Read `.github/pull_request_template.md` from the repo root | ||||||||||||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Handle both common PR template locations. Limiting to Proposed fix- - Read `.github/pull_request_template.md` from the repo root
+ - Read PR template from the repo root using fallback order:
+ 1. `.github/pull_request_template.md`
+ 2. `pull_request_template.md`
+ - If neither exists, ask the user before drafting📝 Committable suggestion
Suggested change
🧰 Tools🪛 LanguageTool[uncategorized] ~21-~21: The official name of this software platform is spelled with a capital “H”. (GITHUB) 🤖 Prompt for AI Agents |
||||||||||||
|
|
||||||||||||
| 3. **Determine work item ID**: | ||||||||||||
| - Extract from branch name if it contains an identifier (e.g., `chore/silo-1146-foo` → `SILO-1146`, `feat/web-1234-x` → `WEB-1234`) | ||||||||||||
| - If not found in branch name, ask the user | ||||||||||||
|
|
||||||||||||
| 4. **Draft the PR** using the template from step 2: | ||||||||||||
|
|
||||||||||||
| **Title**: `[WORK-ITEM-ID] <type>: <concise summary>` (under 70 chars) | ||||||||||||
| - Type reflects the change: `fix`, `feat`, `chore`, `refactor`, `docs`, `perf`, etc. | ||||||||||||
|
|
||||||||||||
| **Body**: Fill in every section from the PR template based on the actual diff: | ||||||||||||
| - **Description** — Clear, concise summary of what the PR does and why. Focus on the "what" and "why", not line-by-line changes. Mention important implementation decisions. | ||||||||||||
| - **Type of Change** — Check the appropriate box(es): Bug fix, Feature, Improvement, Code refactoring, Performance improvements, Documentation update. | ||||||||||||
| - **Screenshots and Media** — Leave a placeholder: `<!-- Add screenshots here -->` | ||||||||||||
|
|
||||||||||||
| - **Test Scenarios** — Suggest concrete scenarios grounded in the actual changes (e.g., "Navigate to project settings and verify the new toggle works"), not generic ones. | ||||||||||||
| - **References** — Include the work item ID, any linked issues the user mentions, and any Sentry issue links/IDs (e.g., `SENTRY-ABC123` or Sentry URLs) referenced earlier in the conversation. | ||||||||||||
|
|
||||||||||||
| Append a Claude Code session line at the bottom of the body. | ||||||||||||
|
|
||||||||||||
| 5. **Push and create** (in parallel where possible): | ||||||||||||
| - Push branch with `-u` if no upstream is set | ||||||||||||
| - Create PR via `gh pr create` using a HEREDOC for the body | ||||||||||||
|
|
||||||||||||
| 6. **Return the PR URL** to the user. | ||||||||||||
|
|
||||||||||||
| ## Example Title | ||||||||||||
|
|
||||||||||||
| ``` | ||||||||||||
| [SILO-1146] fix: allow relative URLs for configuration_url and improve app tile visibility | ||||||||||||
| ``` | ||||||||||||
|
Comment on lines
+49
to
+51
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Add a language tag to the example code fence. This currently violates markdownlint MD040. Proposed fix-```
+```text
[SILO-1146] fix: allow relative URLs for configuration_url and improve app tile visibilityVerify each finding against current code. Fix only still-valid issues, skip the In @.claude/skills/create-pull-request/SKILL.md around lines 49 - 51, The fenced |
||||||||||||
|
|
||||||||||||
| ## Guidelines | ||||||||||||
|
|
||||||||||||
| - Keep the description concise but informative | ||||||||||||
| - Use bullet points when listing multiple changes | ||||||||||||
| - Focus on user-facing impact, not implementation details | ||||||||||||
| - Don't fabricate test scenarios that aren't relevant to the actual changes | ||||||||||||
|
|
||||||||||||
| ## Common Mistakes | ||||||||||||
|
|
||||||||||||
| - Summarizing only the latest commit instead of all commits on the branch | ||||||||||||
| - Forgetting to check for an upstream before pushing | ||||||||||||
| - Using a work item ID format that doesn't match the branch convention | ||||||||||||
| - Wrapping the PR body in a code fence when passing it to `gh pr create` | ||||||||||||
This file was deleted.
This file was deleted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Align cross-skill reference with the actual skill name.
Line 3 says
create-pr, but the defined skill iscreate-pull-request. This can confuse invocation/discovery in prompts and docs.Proposed fix
🤖 Prompt for AI Agents