Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion apps/api/plane/authentication/adapter/base.py
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@ def sanitize_email(self, email):
try:
validate_email(email)
except ValidationError:
self.logger.warning(f"Email is not valid: {email}")
self.logger.warning("Email is not valid")
raise AuthenticationException(
error_code=AUTHENTICATION_ERROR_CODES["INVALID_EMAIL"],
error_message="INVALID_EMAIL",
Expand Down
8 changes: 2 additions & 6 deletions apps/api/plane/authentication/adapter/oauth.py
Original file line number Diff line number Diff line change
Expand Up @@ -90,12 +90,8 @@ def get_user_response(self):
response.raise_for_status()
return response.json()
except requests.RequestException:
self.logger.warning(
"Error getting user response",
extra={
"headers": headers,
},
)
# Do not log headers here: they carry the access token
self.logger.warning("Error getting user response")
code = self.authentication_error_code()
raise AuthenticationException(error_code=AUTHENTICATION_ERROR_CODES[code], error_message=str(code))

Expand Down
10 changes: 3 additions & 7 deletions apps/api/plane/authentication/provider/oauth/github.py
Original file line number Diff line number Diff line change
Expand Up @@ -156,13 +156,9 @@ def set_user_data(self):

if self.organization_id:
if not self.is_user_in_organization(user_info_response.get("login")):
self.logger.warning(
"User is not in organization",
extra={
"organization_id": self.organization_id,
"user_login": user_info_response.get("login"),
},
)
# Do not log the organization id or user login here:
# the configuration values must not end up in logs
self.logger.warning("User is not in organization")
raise AuthenticationException(
error_code=AUTHENTICATION_ERROR_CODES["GITHUB_USER_NOT_IN_ORG"],
error_message="GITHUB_USER_NOT_IN_ORG",
Expand Down
Binary file modified packages/editor/src/core/extensions/custom-link/extension.tsx
Binary file not shown.
Loading