fix(i18n): restore {templateName}/{templateType} in cs template toasts - #9848
Conversation
◈ PR Lens
Architecture 1 component touched across 1 lane. Data flow No data-flow sequence changed in this PR. View
Tip The diagrams are links. Click one to open it on the canvas, then press W or click play to walk through the change. 🪧 More tips
Thanks for using PR Lens! It's built by Coldtea, free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 10 included reviews per hour; 9 remain after this review. 📝 WalkthroughWalkthroughThe Czech template success messages now show the template name and type for create, update, and delete actions. ChangesCzech template toast messages
Priority: ⬇️ Low Estimated code review effort: 1 (Trivial) | ~3 minutes Change: Bug fix Merge Risk: ⚪ Minimal · up to The Czech messages match the English interpolation contract, and the template namespace is loaded correctly. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Thanks for the quick merge on this. One thing I noticed while working out how those three slipped in: If you want that covered, it's one extra step in the workflow you already have — no API key, no account, runs offline: # .github/workflows/i18n-sync-check.yml — after the existing check:sync step
- name: i18n placeholder check
run: >-
npx @shipi18n/cli@2 check packages/i18n/src/locales -s en
--severity 'untranslated=off,missing-key=off,orphan-key=off,empty-value=warning'I ran exactly that against It does leave two warnings worth a look, if only for the next translation sync: Happy to open the workflow change as a PR if it's useful, and equally happy if not. Full scan for this repo: https://shipi18n.com/oss#plane |
Three Czech template toast messages lost their interpolation variables in translation, so the toast can't say which template was created, changed or deleted.
packages/i18n/src/locales/cs/template.json)templates.toasts.create.success.message{templateName}, the {templateType} template, is now available…{templateName} byla úspěšně vytvořena…(no{templateType}){templateName} ({templateType}) byla úspěšně vytvořena…templates.toasts.update.success.message{templateName}, the {templateType} template, was changed.{templateName} byla úspěšně aktualizována…{templateName} ({templateType}) byla úspěšně aktualizována…templates.toasts.delete.success.message{templateName}, the {templateType} template, has now been deleted…Šablona byla úspěšně smazána!(both dropped)Šablona {templateName} ({templateType}) byla úspěšně smazána!Existing Czech wording kept; only the variables are restored (3 lines). Native speakers, feel free to rephrase — the point is just that both values render again.
Found with an open-source i18n placeholder checker I maintain (shipi18n); each string was checked by hand against
en/template.json. Note the repo'si18n-sync-checkCI verifies key parity but not placeholder parity, which is how these slipped through. Full scan for this repo: https://shipi18n.com/oss#planeSummary by CodeRabbit