replace tqdm, termcolor, tabulate with rich - #2374
Merged
Merged
Conversation
Comment on lines
-150
to
-152
| # Ghidrathon interpreter cannot properly handle | ||
| # the TMonitor thread that is created via a monitor_interval | ||
| # > 0 |
Collaborator
There was a problem hiding this comment.
before merge we'll have to test and ensure the new implementation also works under Ghidra, which has some weird restrictions.
Collaborator
|
Let's also add a few more rendering tests and |
williballenthin
approved these changes
Sep 26, 2024
williballenthin
left a comment
Collaborator
There was a problem hiding this comment.
please address the logging configuration comments, and then we're ready to go! thanks @s-ff
this commit sets up logging in `capa.main` and uses a shared `log_console` in `capa.helpers` for logging purposes
williballenthin
approved these changes
Sep 27, 2024
| logging.basicConfig(level=logging.DEBUG) | ||
| logging.getLogger().setLevel(logging.DEBUG) | ||
| else: | ||
| logging.basicConfig(level=logging.INFO) |
Collaborator
There was a problem hiding this comment.
good fix, thanks for remembering this
|
|
||
| # use RichHandler for root logger | ||
| logging.getLogger().addHandler(rich_handler) | ||
|
|
Collaborator
There was a problem hiding this comment.
looks great, thank you!
Collaborator
|
Thanks, the new output looks great in my testing so far! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #2100
Checklist