Conversation
There was a problem hiding this comment.
Please add bug fixes, new features, breaking changes and anything else you think is worthwhile mentioning to the master (unreleased) section of CHANGELOG.md. If no CHANGELOG update is needed add the following to the PR description: [x] No CHANGELOG update needed
github-actions
Bot
dismissed
their stale review
September 26, 2024 20:43
CHANGELOG updated or no update needed, thanks! 😄
williballenthin
approved these changes
Sep 27, 2024
| assert_never(value) | ||
|
|
||
| yield API(call.api), ch.address | ||
| for name in capa.features.extractors.helpers.generate_symbols("", call.api): |
Collaborator
There was a problem hiding this comment.
we should update this API to accept None when the dll isn't present, not the empty string. But that can happen in another PR.
| ("0000a657", "process=(1180:3052)", capa.features.common.String("nope"), False), | ||
| # thread/api calls | ||
| ("0000a657", "process=(2900:2852),thread=2904", capa.features.insn.API("RegQueryValueExA"), True), | ||
| ("0000a657", "process=(2900:2852),thread=2904", capa.features.insn.API("RegQueryValueEx"), True), |
Collaborator
There was a problem hiding this comment.
perfect, thanks for adding tests
mr-tz
approved these changes
Sep 27, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #2408
This fixes A/W API detection for CAPE, VMRay, and drakvuf where capa rules that specified A/W APIs without the A/W could not be matched e.g. https://github.com/mandiant/capa-rules/blob/627395d6f19dc76894bbf7d365d28d083fab67cf/lib/create-or-open-registry-key.yml#L4