capa Explorer Web: improve url navigation - #2425
Merged
Merged
Conversation
This commit enhances the navigation guard for the /analysis route to provide a better user experience when loading data from a URL: Previously: users browsing to /analysis were always redirected to the homepage (/). With this commit: - If a user accesses /analysis without an rdoc parameter, they are still redirected to the homepage. - If a user accesses /analysis with an rdoc parameter, the following occurs: The user is redirected to the homepage (/) and the rdoc parameter is preserved in the URL, capa Explorer Web then loads the rdoc from URL.
fariss
requested review from
mr-tz and
williballenthin
and removed request for
mr-tz
October 1, 2024 15:55
fariss
marked this pull request as ready for review
October 1, 2024 15:56
mr-tz
approved these changes
Oct 1, 2024
mr-tz
left a comment
Collaborator
There was a problem hiding this comment.
looks good to me, thank you!
Collaborator
will you create a separate PR for this? |
Collaborator
Author
mr-tz
reviewed
Oct 1, 2024
mr-tz
reviewed
Oct 1, 2024
Collaborator
|
Thanks @s-ff! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #2419
This PR enhances the navigation in capa Explorer Web by making sure the links generated are shareable. Preview.
Previously: users browsing to
/analysiswere always redirected to the homepage/.With this PR:
/analysiswithout an rdoc query parameter set in the URL, they are still redirected to the homepage./analysiswith the rdoc query parameter set, capa Explorer Web loads from that URL instead of redirecting to homepage.Checklist