Skip to content

cape: models: parse minimum fields required for analysis - #2607

Merged
mike-hunhoff merged 2 commits into
masterfrom
fix/2539
Feb 19, 2025
Merged

cape: models: parse minimum fields required for analysis#2607
mike-hunhoff merged 2 commits into
masterfrom
fix/2539

Conversation

@mike-hunhoff

@mike-hunhoff mike-hunhoff commented Feb 18, 2025

Copy link
Copy Markdown
Collaborator

Only parse the CAPE fields required for analysis and ignore the rest. This drastically reduces the bug surface and number of CAPE models that we must maintain to avoid pydantic errors (e.g. #2539). Fields that were never used have been commented out (to remain as documentation) and we can add fields back in the future, as/if needed.

Fixes #2539.

@mike-hunhoff
mike-hunhoff requested a review from a team February 18, 2025 21:11

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add bug fixes, new features, breaking changes and anything else you think is worthwhile mentioning to the master (unreleased) section of CHANGELOG.md. If no CHANGELOG update is needed add the following to the PR description: [x] No CHANGELOG update needed

@github-actions
github-actions Bot dismissed their stale review February 18, 2025 21:14

CHANGELOG updated or no update needed, thanks! 😄

@williballenthin williballenthin left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good idea

@mike-hunhoff
mike-hunhoff merged commit a278bf5 into master Feb 19, 2025
@mike-hunhoff
mike-hunhoff deleted the fix/2539 branch February 19, 2025 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CAPE model errors - CapeReport.procmemory

2 participants