ci: bump binja min version - #2763
Conversation
Summary of ChangesHello @mike-hunhoff, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request updates a continuous integration test to reflect a new minimum expected version for Binary Ninja. This ensures that the project's compatibility checks align with the updated requirements for the Binary Ninja API, specifically bumping the minor version from 1 to 2. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Please add bug fixes, new features, breaking changes and anything else you think is worthwhile mentioning to the master (unreleased) section of CHANGELOG.md. If no CHANGELOG update is needed add the following to the PR description: [x] No CHANGELOG update needed
There was a problem hiding this comment.
Code Review
This pull request updates the minimum required version for Binary Ninja. The corresponding test has been updated, but it currently asserts an exact version match rather than a minimum version. My feedback suggests modifying the test to check for a version greater than or equal to the new minimum, which will make the CI more robust against future Binary Ninja updates.
CHANGELOG updated or no update needed, thanks! 😄
Checklist