Skip to content

ci: bump binja min version - #2763

Merged
mike-hunhoff merged 2 commits into
masterfrom
ci/binja/bump/version
Nov 17, 2025
Merged

ci: bump binja min version#2763
mike-hunhoff merged 2 commits into
masterfrom
ci/binja/bump/version

Conversation

@mike-hunhoff

Copy link
Copy Markdown
Collaborator

Checklist

  • No CHANGELOG update needed
  • No new tests needed
  • No documentation update needed

@mike-hunhoff
mike-hunhoff requested a review from a team November 17, 2025 16:57
@gemini-code-assist

Copy link
Copy Markdown
Contributor

Summary of Changes

Hello @mike-hunhoff, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request updates a continuous integration test to reflect a new minimum expected version for Binary Ninja. This ensures that the project's compatibility checks align with the updated requirements for the Binary Ninja API, specifically bumping the minor version from 1 to 2.

Highlights

  • Binary Ninja Version Update: The minimum required Binary Ninja version asserted in the test suite has been updated from 5.1 to 5.2.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add bug fixes, new features, breaking changes and anything else you think is worthwhile mentioning to the master (unreleased) section of CHANGELOG.md. If no CHANGELOG update is needed add the following to the PR description: [x] No CHANGELOG update needed

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the minimum required version for Binary Ninja. The corresponding test has been updated, but it currently asserts an exact version match rather than a minimum version. My feedback suggests modifying the test to check for a version greater than or equal to the new minimum, which will make the CI more robust against future Binary Ninja updates.

Comment thread tests/test_binja_features.py
@github-actions
github-actions Bot dismissed their stale review November 17, 2025 16:59

CHANGELOG updated or no update needed, thanks! 😄

@mike-hunhoff
mike-hunhoff merged commit 8d39765 into master Nov 17, 2025
27 checks passed
@mike-hunhoff
mike-hunhoff deleted the ci/binja/bump/version branch November 17, 2025 18:10
kami922 pushed a commit to kami922/capa that referenced this pull request Jan 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants