fix(lint): disable rule caching during linting

[Maijin]

• Disabling the rule cache during linting ensures validation runs against the current state of files on disk rather than stale cached data, effectively preventing false positives when rules are renamed or modified.

Checklist

• No CHANGELOG update needed

• No new tests needed

• No documentation update needed

[gemini-code-assist]

Summary of Changes

Hello @Maijin, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request improves the reliability of the linting process by ensuring that rule caching is explicitly disabled during linting. This prevents the use of outdated cached rule definitions, thereby eliminating a source of false positives and ensuring that linting results accurately reflect the current state of the codebase.

Highlights

• Linting Accuracy: The pull request disables rule caching specifically during the linting process to ensure that validation always uses the most current state of files on disk.
• Preventing False Positives: This change addresses potential false positives that could arise from stale cached data, especially when linting rules are renamed or modified.
• Cache Control: A new "enable_cache" argument has been introduced in the "get_rules_from_cli" function, allowing explicit control over whether rule caching is active.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request disables rule caching during linting to prevent false positives from stale cache data. The implementation correctly adds a mechanism to disable caching and uses it in the lint script. I've added a couple of suggestions: one to improve code conciseness in capa/main.py and another to maintain consistency in CHANGELOG.md. Overall, this is a good and necessary fix.

[williballenthin]

have you encountered this being an issue @Maijin? i believe our rule caching logic checks hashes/timestamps of the rule files and should therefore cache edits.

[Maijin]

Yeah basically when I was renaming the files (via Antigravity), the linter kept using the old names and failing and It took a while to figure out that it was the cache issue. Deleting the cache files fixed it so I'm suggesting this PR to completely remove this issue.

[mr-tz]

thanks, just two suggestions regarding the documentation

[Maijin]

@mr-tz done

[mr-tz]

thanks