Windows: build with node@4.2.1

[wilhelmberg]

@springmeyer @flippmoke

Builds fine with node@0.12.7, but with node@4.2.1 I get this:

"c:\mb\windows-builds-64\packages\node-mapnik\build\binding.sln" (default target) (1) ->
"c:\mb\windows-builds-64\packages\node-mapnik\build\action_after_build.vcxproj.metaproj" (default target) (2) ->
"c:\mb\windows-builds-64\packages\node-mapnik\build\mapnik.vcxproj.metaproj" (default target) (3) ->
"c:\mb\windows-builds-64\packages\node-mapnik\build\mapnik.vcxproj" (default target) (7) ->
(Link target) ->
  mapnik_vector_tile.obj : error LNK2001: unresolved external symbol "__declspec(dllimport) protected: virtual void __cdecl std:: bad_cast::_Doraise(void)const " (__imp_?_Doraise@bad_cast@std@@MEBAXXZ) [c:\mb\windows-builds-64\packages\node-mapnik\build\mapni k.vcxproj]
  mapnik_vector_tile.obj : error LNK2001: unresolved external symbol "__declspec(dllimport) public: __cdecl std::bad_cast::bad_ca st(char const *)" (__imp_??0bad_cast@std@@QEAA@PEBD@Z) [c:\mb\windows-builds-64\packages\node-mapnik\build\mapnik.vcxproj]
  c:\mb\windows-builds-64\packages\node-mapnik\build\Release\mapnik.node : fatal error LNK1120: 2 unresolved externals [c:\mb\win dows-builds-64\packages\node-mapnik\build\mapnik.vcxproj]

[damylen]

Same here, are there any plans to support node4? I would like to integrate this with another program that requires node4.

[springmeyer]

@BergWerkGIS can you try it again? Those errors look like something unrelated to node-mapnik.

[wilhelmberg]

Y, already tried yesterday. Getting some new strange errors like

mocha cannot be installed as a module of itself

when using self built node.exe.

When trying to use nodejs's node.exe, node-gyp and/or node-pre-gyp fail to download the node.lib as the directory structure seems to have changed:

before:

..../v0.12.7/node.lib 
..../v0.12.7/x64/node.lib 

now:

..../v4.2.1/win-x86/node.lib 
..../v4.2.1/win-x64/node.lib 

see:
https://nodejs.org/dist/v4.2.1/

[wilhelmberg]

Fresh build of mapnik@master and node-mapnik@master got me to the same error as in the original post.
Again, node@0.12.7 works.

[wilhelmberg]

Since we are building everything else with /MD, this seems to be the problem:

"target_name": "vector_tile",
      "type": "static_library",

node-mapnik/binding.gyp

Line 48 in b4a88d2

"type": "static_library",

"type": "shared_library" get's me past the previous error, but other changes to binding.gyp are needed, too.

[springmeyer]

Great findings, though odd this only comes up with 4.2.1. I wonder if 4.2.2 would be any different.

but other changes to binding.gyp are needed, too.

What are you hitting?

[wilhelmberg]

Error message is in first post.

Some hints:

• /MT vs. /MD https://social.msdn.microsoft.com/forums/vstudio/en-US/70cbb430-0a0c-4e04-8d1b-a036a03bba8a/link-error-2001unresolved-external-symbol
• could happen anywhere a dynamic cast is used, but that only applies during runtime http://stackoverflow.com/a/23391864 http://en.cppreference.com/w/cpp/types/bad_cast

[wilhelmberg]

ah, sorry, new message: cannot find vector_tile.lib

Already stumbled upon this when trying to build NET-Mapnik with latest mapnik at that time.
Also didn't find a solution, that's why it is commented: https://github.com/BergWerkGIS/NET-Mapnik/blob/8ea1d4d72ff0ea22bd91d1375483522ed5c6dcc4/NETMapnik.gyp#L25-L51

doing a node@5.1.0 build ATM, will try node-mapnik with that.

[wilhelmberg]

with node@5.1.0:

node-pre-gyp ERR! stack Error: Unsupported target version: 5.1.0

[springmeyer]

that can be fixed by running https://github.com/mapbox/node-pre-gyp/blob/master/scripts/abi_crosswalk.js and the committing to master and the pointing node-mapnik at node-pre-gyp master branch

[wilhelmberg]

yeah, I just went back to 5.0.0 that's the last one in abi_crosswalk.json

[springmeyer]

as far as the vector_tile.lib issue don't know why it would not be found. but a quick workaround might be to add the .cc file to the list of sources that include the rest of the node c++ files. the reason i made it separate was just to be able to selectively suppress warnings.

[springmeyer]

@BergWerkGIS - just made a branch (https://github.com/mapnik/node-mapnik/compare/gyp-simplify) that should workaround that vector_tile.lib issue by avoiding its use. Can you see if this works with node 5?