fix(lint): handle stdout write errors and use reflect.Pointer - #221
Open
iamlasse wants to merge 2 commits into
Open
fix(lint): handle stdout write errors and use reflect.Pointer#221iamlasse wants to merge 2 commits into
iamlasse wants to merge 2 commits into
Conversation
Add internal/commits with pure Normalize/validate functions enforcing the project's Conventional Commits rules (known type set, lowercase type, lowercase subject, 72-char subject limit, whitespace trimming, and 72-column body wrapping). Wire it into the CLI as 'nightshift commit normalize' (positional, --file, and stdin sources; --check to validate only), ship a commit-msg git hook under scripts/, and document the format and installation in docs/commit-messages.md. Nightshift-Task: commit-normalize Nightshift-Ref: https://github.com/marcus/nightshift
- errcheck: check the error return of fmt.Fprintln(os.Stdout, ...) in both branches of commit normalize - govet: replace deprecated reflect.Ptr with the reflect.Pointer synonym in config.go (no behavior change) Nightshift-Task: lint-fix Nightshift-Ref: https://github.com/marcus/nightshift Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the 4 remaining
golangci-lintfindings so the repo lints clean with default settings:cmd/nightshift/commands/commit.go— thecommit normalizecommand calledfmt.Fprintln(os.Stdout, normalized)without checking the write error in both the--checkbranch and the normal path. Both now return the error.cmd/nightshift/commands/config.go— replaced the deprecatedreflect.Ptrconstant with its Go 1.18+ synonymreflect.PointerinprintStructandisZero. No behavior change.Verification
gofmt -l .— cleango vet ./...— cleangolangci-lint run --timeout 5m— 0 issuesgo build ./...— okgo test ./...— all packages pass🤖 Generated with Claude Code
Automated by nightshift