refactor: modernize interface{} to any in config command - #225
Open
ke23y wants to merge 1 commit into
Open
Conversation
Replaces the pre-Go-1.18 interface{} type with the any alias across
cmd/nightshift/commands/config.go for consistency with current Go style.
Nightshift-Task: lint-fix
Nightshift-Ref: https://github.com/marcus/nightshift
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
interface{}type with theanyalias acrosscmd/nightshift/commands/config.go(8 occurrences), a mechanical, behavior-preserving modernization consistent with current Go style conventions and commonly flagged by static analysis tooling.golangci-lint(the linter configured in.github/workflows/ci.yml) could not be run in this sandbox because network access toproxy.golang.orgis blocked.gofmt -l -s .,go vet ./..., andgo build ./...were all clean before and after this change. A manual scan for common default-linter violations (unchecked errors, ineffectual assignments, unclosed resources) found no other issues.Test plan
gofmt -l -s .— cleango vet ./...— cleango build ./...— succeedsgo test ./...— passes exceptTestCurrentBranchininternal/orchestrator, which fails identically onmaindue to a sandbox permission restriction unrelated to this change (cannot copy git hook templates), not a regression from this PRgolangci-lint run— not run locally (network access to proxy.golang.org unavailable in this sandbox); recommend running in CINightshift-Task: lint-fix
Nightshift-Ref: https://github.com/marcus/nightshift
Automated by nightshift