fix(lint): handle Fprintln errors and use reflect.Pointer - #238
Open
iamlasse wants to merge 2 commits into
Open
Conversation
Add internal/commits with pure Normalize/validate functions enforcing the project's Conventional Commits rules (known type set, lowercase type, lowercase subject, 72-char subject limit, whitespace trimming, and 72-column body wrapping). Wire it into the CLI as 'nightshift commit normalize' (positional, --file, and stdin sources; --check to validate only), ship a commit-msg git hook under scripts/, and document the format and installation in docs/commit-messages.md. Nightshift-Task: commit-normalize Nightshift-Ref: https://github.com/marcus/nightshift
- errcheck: propagate the error return of fmt.Fprintln in the commit normalize command instead of discarding it - govet: replace the deprecated reflect.Ptr alias with reflect.Pointer Nightshift-Task: lint-fix Nightshift-Ref: https://github.com/marcus/nightshift
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the 4 issues reported by
golangci-lint run(v2.12.2, default config):cmd/nightshift/commands/commit.go:55,58— the return error offmt.Fprintln(os.Stdout, normalized)in thecommit normalizecommand was discarded; it is now propagated as the command's error.cmd/nightshift/commands/config.go:373,411— replaced the deprecatedreflect.Ptralias withreflect.Pointer(identical value, no behavior change).Verification
golangci-lint run→ 0 issues (was 4)go build ./...→ passgo test ./...→ all packages passgofmt -l .→ cleanNightshift-Task: lint-fix
Nightshift-Ref: https://github.com/marcus/nightshift
Automated by nightshift