Skip to content

Fix hosted review policy context - #209

Merged
marcus merged 2 commits into
marcus:mainfrom
gvorwaller:fix/web-review-actions
Aug 27, 2026
Merged

Fix hosted review policy context#209
marcus merged 2 commits into
marcus:mainfrom
gvorwaller:fix/web-review-actions

Conversation

@gvorwaller

@gvorwaller gvorwaller commented Aug 27, 2026

Copy link
Copy Markdown
Contributor

Summary

  • resolve review policy through the shared helper for both local and hosted handlers
  • make hosted routes use td's documented trusted default while preserving process-wide overrides
  • centralize policy resolution across review, approve, close, and transition discovery

Bug

Hosted handlers have no local BaseDir, so review-policy checks skipped the resolver and silently fell back to strict. An involved td-watch browser session therefore received only reject in available_transitions, even though the default policy is trusted and an attributed or acknowledged approval is valid.

Verification

  • make test
  • regression test fails under the old fallback with transitions=[reject], then passes with this change
  • focused go test ./internal/serve ./internal/api ./internal/features

@marcus
marcus merged commit f20908a into marcus:main Aug 27, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants