Skip to content

fix: start every scriptlet range at its $ - #244

Merged
DylanPiercey merged 1 commit into
mainfrom
dpiercey-ws-prettier-marko-async-ulp3vg
Sep 23, 2026
Merged

DylanPiercey merged 1 commit into
mainfrom
dpiercey-ws-prettier-marko-async-ulp3vg

Conversation

@DylanPiercey

Copy link
Copy Markdown
Contributor

A scriptlet's range started at its $ inside an HTML body, but at the space after it at the root and in concise content, because CONCISE_HTML_CONTENT skipped the $ before entering INLINE_SCRIPT. It now enters first, as HTML_CONTENT does, so onScriptlet reports $ var a = 1; everywhere. The value range is unchanged; the concise scriptlet snapshots move back one column.

🤖 Generated with Claude Code

Concise content skipped the `$` before entering INLINE_SCRIPT, so a scriptlet
at the root or in concise mode started at the space after it, while one in an
HTML body started at the `$`. Both now start at the `$`.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
@changeset-bot

changeset-bot Bot commented Sep 23, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 9452de1

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
htmljs-parser Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@DylanPiercey
DylanPiercey merged commit 9d46912 into main Sep 23, 2026
8 checks passed
@codecov

codecov Bot commented Sep 23, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.95%. Comparing base (037f4ef) to head (9452de1).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #244   +/-   ##
=======================================
  Coverage   99.95%   99.95%           
=======================================
  Files          34       34           
  Lines        4576     4576           
  Branches      879      879           
=======================================
  Hits         4574     4574           
  Misses          2        2           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions github-actions Bot mentioned this pull request Sep 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant