Repository navigation
Restore first-run SCL, IP and Excel launcher cards - #162
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f89e0119ac
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| /// </summary> | ||
| public partial class MainWindow | ||
| { | ||
| private static readonly bool FirstRunLauncherRepairRegistered = RegisterFirstRunLauncherRepair(); |
There was a problem hiding this comment.
Register the repair from a guaranteed startup path
On a normal startup where no MainWindow static field is accessed before Loaded, this unused field does not guarantee that RegisterFirstRunLauncherRepair() runs: without an explicit static constructor the type is emitted with beforefieldinit, so its initialization may be deferred beyond instance construction and the Loaded event. In that case the handler is never registered in time, RestoreFirstRunLauncherContract is not queued, and the first-run cards remain missing; register this through a module initializer or another startup path that is explicitly invoked.
Useful? React with 👍 / 👎.
Regression
P2.1 added the industrial hero tint as a
Border. The legacy first-run launcher intentionally identified the original general-testing card withheroGrid.Children.OfType<Border>().SingleOrDefault(). When the decorative tint existed first, the hero contained two Borders, the launcher setup failed, and the whole center workflow (general IED onboarding + IO List Excel import card) disappeared visually.Fix
InstallFirstRunTestingChoicesworkflow and Excel import engine;Open SCL,Add IED by IP, andOpen Project;Import Excel IO Listlabel on the FAT card while retaining the existing.xlsxhandler and ARSAS project continuation action.Regression guard
Adds focused tests that lock the P2 overlay repair order and the SCL/IP/Excel first-run operator paths.
No IEC 61850 engine, FAT evidence, device state, or project-data behavior is changed.