Skip to content

fix: show every static DataSet member in Signal Selector - #180

Merged
masarray merged 4 commits into
mainfrom
fix/fcd-dataset-signal-selector-completeness
Aug 15, 2026
Merged

masarray merged 4 commits into
mainfrom
fix/fcd-dataset-signal-selector-completeness

Conversation

@masarray

Copy link
Copy Markdown
Owner

Problem

ARSAS v1.6.31 can discover the physical IED DataSet directory, but FCD/DataObject-level members can still disappear before the Signal Selector when no unique primary DataAttribute leaf is resolved. This is common in Siemens SIPROTEC SCL/DataSet definitions where daName is empty.

Fix

  • Pin ARIEC61850 to engine PR Add Indonesian high-value IEC 61850 pages #76 / commit 52f8e383711f63d4a37af742fc92243be80aa0d6.
  • Consume the new engine-owned complete DataSet selection inventory rather than only GetMandatoryPrimarySignals().
  • Preserve unresolved FCD members as visible DataSet rows without guessing a leaf reference.
  • Keep user selection independent (IsSelected=false).
  • Mark unresolved rows explicitly as primary leaf unresolved instead of claiming a proven MMS polling target.

Regression coverage

  • Siemens-like 2 DataSets / 58 FCD-only members: Signal Selector inventory must contain 58/58 rows (36 digital + 22 analog).
  • Reopening the selector must not duplicate recovered FCD rows.

This closes the gap between DataSet directory discovered and DataSet member visible to the user.

@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, you can upgrade your account or add credits to your account and enable them for code reviews in your settings.

@masarray
masarray merged commit 3192ab2 into main Aug 15, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant