fix: show every static DataSet member in Signal Selector - #180
Merged
Merged
Conversation
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
ARSAS v1.6.31 can discover the physical IED DataSet directory, but FCD/DataObject-level members can still disappear before the Signal Selector when no unique primary DataAttribute leaf is resolved. This is common in Siemens SIPROTEC SCL/DataSet definitions where
daNameis empty.Fix
52f8e383711f63d4a37af742fc92243be80aa0d6.GetMandatoryPrimarySignals().DataSetrows without guessing a leaf reference.IsSelected=false).primary leaf unresolvedinstead of claiming a proven MMS polling target.Regression coverage
This closes the gap between
DataSet directory discoveredandDataSet member visible to the user.