Skip to content

Polish global search clear control with Lucide icon - #198

Merged
masarray merged 10 commits into
mainfrom
ui/modern-global-search-clear
Aug 16, 2026
Merged

masarray merged 10 commits into
mainfrom
ui/modern-global-search-clear

Conversation

@masarray

Copy link
Copy Markdown
Owner

Field issue

The global search clear affordance in IEC 61850 Signal Selection used a raw × text glyph inside the generic MiniChipButton style. On the current Windows/DPI layout it looked visually heavy, slightly clipped/off-center, and unlike a modern embedded search-field clear control.

Fix

  • Replace the raw multiplication-sign glyph with the existing vector LucideX resource.
  • Use a dedicated 28×28 DIP embedded hit target with a centered 14×14 Lucide icon.
  • Transparent at rest; subtle ARSAS blue-gray hover/pressed surfaces and an internal blue keyboard-focus ring.
  • Remove the permanent mini-chip chrome so the clear affordance visually belongs to the search field rather than looking like a toolbar button.
  • Hide the clear control automatically while the global search is empty; it appears only when there is text to clear.
  • Preserve the existing ClearGlobalFilter_Click behavior.
  • Add AutomationProperties.Name="Clear global search" and keep the tooltip concise.
  • Keep clipping disabled on the clear control so DPI antialias edges are not cut.

Regression coverage

Adds an XAML regression guard that locks the Lucide resource, 28 DIP hit target, 14 DIP icon, empty-search visibility trigger, accessibility name, and absence of the legacy Content="×" / MiniChipButton implementation.

Final branch contains only SignalSelectionWizardWindow.xaml and the regression test; temporary patch tooling was removed before PR creation.

@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, you can upgrade your account or add credits to your account and enable them for code reviews in your settings.

@masarray
masarray merged commit 2870d4c into main Aug 16, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant