Polish global search clear control with Lucide icon - #198
Merged
Merged
Conversation
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Field issue
The global search clear affordance in
IEC 61850 Signal Selectionused a raw×text glyph inside the genericMiniChipButtonstyle. On the current Windows/DPI layout it looked visually heavy, slightly clipped/off-center, and unlike a modern embedded search-field clear control.Fix
LucideXresource.ClearGlobalFilter_Clickbehavior.AutomationProperties.Name="Clear global search"and keep the tooltip concise.Regression coverage
Adds an XAML regression guard that locks the Lucide resource, 28 DIP hit target, 14 DIP icon, empty-search visibility trigger, accessibility name, and absence of the legacy
Content="×"/MiniChipButtonimplementation.Final branch contains only
SignalSelectionWizardWindow.xamland the regression test; temporary patch tooling was removed before PR creation.