Skip to content

FAT v2 consolidated: shared SCL workspace, V1/V2 capture and report - #236

Merged
masarray merged 227 commits into
mainfrom
feat/fat-v2-workspace-ui
Sep 3, 2026
Merged

masarray merged 227 commits into
mainfrom
feat/fat-v2-workspace-ui

Conversation

@masarray

@masarray masarray commented Sep 1, 2026 •

Copy link
Copy Markdown
Owner

Canonical FAT development line

This PR is now the single active FAT v2 integration line. Earlier stacked/divergent FAT PRs #232, #233, #234, #235, #238 and #239 were closed as superseded; their branches/commits remain preserved for history.

Current branch: feat/fat-v2-workspace-ui
Target: main

Consolidated contract

  • one shared Engineering/FAT SCL workspace and shared signal-selection authority
  • static DataSet membership remains deterministic authority when selected
  • manual Engineering selections can materialize FAT rows without hijacking FAT TEST scope
  • WorkspaceSelected, FAT TestEnabled, and FAT Remove/Restore disposition are independent authorities
  • per-IED connection/session isolation
  • generic Value 1 / Value 2 evidence, auto capture, operator capture/recapture, append-only journal
  • extended multi-row selection and right-click Recapture
  • Remove from FAT excludes the row from FAT testing and FAT reports while preserving Engineering selection/evidence for restore
  • persistence/package/report support for shared workspace and FAT overlay
  • existing semantic structured report projection retained

P0 duplicate-runtime regression — fixed

PR #241 was merged into this branch at merge commit f9c2558b0984c3709d0be8baf644e39ebf4bfa4a.

The shared-workspace bridge now enforces:

  • distinct static + static memberships sharing one runtime scalar: ALLOW
  • static + manual resolving to the same runtime scalar: collapse manual selection into static authority; do not create duplicate FAT row
  • manual + manual same runtime scalar: do not duplicate
  • stale redundant manual overlays are retired from WorkspaceSelected without deleting their TEST/disposition/evidence state
  • strict duplicate preflight remains fail-closed and unchanged

Regression covers the observed TimeSynchrnz / GGIO2.TimeSynchrnz.stVal shape. #241 exact head 20499f29f337482fa788054b2f9a41555503935b passed focused FAT/IO, SV evidence, and full ARSAS build/regression/publish/smoke before merge.

Final merge gate

Keep this PR DRAFT while exact consolidated-head CI and controlled physical IED retest are pending. Before merge to main, qualify the exact final head through focused FAT/IO, full ARSAS build/regression, SV evidence validation, Windows installer smoke, and the controlled physical IED workflow.

masarray commented Sep 3, 2026

Copy link
Copy Markdown
Owner Author

Canonical FAT development line after cleanup. PRs #232–#235, #238 and #239 are now closed as superseded; their branches remain preserved. Keep this PR DRAFT while the active P0 shared-workspace duplicate suppression is being fixed: static DataSet membership + manual Engineering selection resolving to the same runtime IEC scalar must collapse to static authority; distinct static+static memberships remain allowed; duplicate preflight guard must stay strict. Do not weaken preflight or delete static authority. After that fix lands, re-run exact-head CI before retarget/merge decisions.

@masarray masarray changed the title FAT v2 P5: generic Value1 Value2 workspace UX FAT v2 consolidated: shared SCL workspace, V1/V2 capture and report Sep 3, 2026
@masarray
masarray changed the base branch from feat/fat-v2-scl-import to main September 3, 2026 06:43
Preserve static DataSet authority while suppressing redundant manual runtime rows. Keep duplicate preflight fail-closed and preserve distinct static membership fan-out.
Align FAT v2 Result with the exact current Value 1 / Value 2 evidence pair while preserving reconnect continuity authority and journal-first evidence ordering.
Merge the reconnect/recovery slice only after revalidating it against the current FAT evidence-assessment base. Focused IO, SV evidence, full application regression, portable publish, and smoke test are green on the refreshed PR head.
@masarray
masarray marked this pull request as ready for review September 3, 2026 10:06
@masarray
masarray merged commit e989150 into main Sep 3, 2026
11 of 15 checks passed
masarray added a commit that referenced this pull request Sep 16, 2026
User approved merge after field validation. Exact-head gates passed: Build #2836, Installer #989, IO #1377, SV #1818, COMTRADE #236.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant