Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 69cc97022a
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| var token = logicalNodeToken.Trim(); | ||
| if (token.Equals("LLN0", StringComparison.OrdinalIgnoreCase)) |
There was a problem hiding this comment.
When an MMS reference flattens a scope prefix into the logical-node token, such as the repository's SystemLLN0$ST$... form in IoTestSmartReferenceMatcherTests, this exact equality check misses LLN0; the subsequent digit stripping removes the significant 0 and derives an owner such as MLLN. Consequently, a reference like SystemLLN0$ST$Mod$stVal is displayed as MLLN Mod rather than LLN0 Mod. Detect a terminal LLN0 before applying the generic instance-number logic.
Useful? React with 👍 / 👎.
Superseded by PR #269. The context-aware FAT signal naming changes were moved into
feat/ied-fascia-connectivity-ledso the test build contains both the new fascia/connection LEDs and the FAT naming fix. This PR is intentionally closed without merge.