Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 991dc255c2
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| // Do not allow the original XAML Checked/Unchecked instance handlers to translate | ||
| // DataGrid container materialization/recycling into a single-selection mutation. | ||
| // RcbExportRow.IsSelected remains the durable selection authority. | ||
| e.Handled = true; |
There was a problem hiding this comment.
When a checkbox is toggled through UI Automation, such as by a screen reader or automation peer, the operation bypasses the DataGrid's preview mouse/key handlers. The two-way binding still changes RcbExportRow.IsSelected, but unconditionally marking the resulting event handled also blocks the XAML handlers, and no P1RefreshLegacyRcbSelectionUi call occurs. For example, unchecking the final row this way leaves the footer showing the old selection and the Export button enabled even though the multi-export path finds no selected rows. Suppress only container-rehydration events, or synchronize the multi-selection UI for genuine toggles that did not pass through the preview handlers.
Useful? React with 👍 / 👎.
Superseded by PR #274. The exact RCB virtualization fix from this PR was copied onto
fix/black-fascia-fat-progress-restoreso the field candidate contains black fascia + LED Stop sync + FAT restore + RCB scroll persistence together. Combined head7508d303a96baa947e17a16d2f319414e79e8042passed Build #2187, IO #1049 and SV #1273. Do not merge this standalone branch because it intentionally started frommainand therefore does not contain PR #274's fascia/FAT changes.