Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 991dc255c2
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| // Do not allow the original XAML Checked/Unchecked instance handlers to translate | ||
| // DataGrid container materialization/recycling into a single-selection mutation. | ||
| // RcbExportRow.IsSelected remains the durable selection authority. | ||
| e.Handled = true; |
There was a problem hiding this comment.
When a checkbox is toggled through UI Automation (for example, a screen reader invoking TogglePattern) rather than mouse or Space-key input, the two-way binding still changes RcbExportRow.IsSelected, but this handler now suppresses both legacy callbacks and the P1 preview handlers never run. Consequently SelectedRow, the footer summaries, and ExportButton.IsEnabled remain stale—for example, unticking the only selected row leaves Export enabled and still reports that row as retained. Preserve a path that synchronizes the multi-selection UI for genuine toggles that do not pass through the preview handlers.
Useful? React with 👍 / 👎.
No longer needed. The RCB virtualization fix was copied directly onto PR #274 and validated there as exact combined head
7508d303a96baa947e17a16d2f319414e79e8042.