Conversation
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This was referenced Sep 19, 2026
Owner
Author
|
Closing as superseded by the production Smart Discovery route that was promoted and physically accepted before v1.6.40, plus the current static DataSet/report-only guards on main. This branch is 124 commits behind current main and still references the old convergence authority path. Its original regression is addressed in the accepted production lineage; merging this branch now would risk reintroducing old engine/evidence/runtime assumptions. Keep this PR as historical diagnosis only. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Physical regression addressed
The invalidated discovery-static candidate exposed two separate regressions.
1. Discovery provenance / entry-point regression
R10 physical acceptance was performed on the Smart Discovery field artifact. That workflow ran
scripts/enable-smart-discovery-capture.ps1before compilation, which injected the provenDiscoverSignalsAsync -> DiscoverSignalsSmartForCaptureAsyncroute plus association-generation reset/control-authority wiring.The repository commit itself did not contain that route. A normal build from the same commit therefore executed the older
DiscoverSignalsAsyncpath: supplemental GetNameList/type/probe/unit work returned, explaining why the later normal build had slow discovery and lacked theSMART-CAPTURE ... TimingMs ...diagnostic marker.This PR promotes that physically proven build transform into normal source and records the provenance correction in the R10 evidence.
2. Live-model Static DataSet projection regression
After model creation, the direct live static path also diverged from the proven opened-SCL path:
Repair
DataSet Signals/Signal Catalogchooser;Safety / acceptance
This PR is a candidate repair, not physical acceptance authority. PR #332 remains invalidated and closed.
Do not merge or publish until: