fix(ci): verify exact triggering commit in Windows build and package - #376
Merged
Merged
Conversation
11 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Root cause
The canonical Windows build cloned a moving PR/branch tip (
git clone --branch), which may differ from GitHub's triggering SHA after a concurrent push. A green check could therefore attest a different source revision than its displayed commit.Change
actions/checkout@v4with exact${{ github.sha }}under the same application sibling path.GITHUB_SHA, and recordARSAS_SOURCE_COMMITin job environment.No engine lock, runtime, Smart Discovery, SCL, reporting, release version, or published binary changes. This secures the source of the same existing build/test/portable smoke job. CI must pass before merge.