fix(source-clean): scan every tracked file and test rejection fixtures - #384
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 6229e275d8
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| # No tracked path receives a whole-file external-identifier exemption. Historical | ||
| # comparison evidence is linked by immutable commit rather than copied into active files. |
There was a problem hiding this comment.
Scan the guard script before skipping its policy literals
When scripts/verify-source-clean.ps1 itself contains a prohibited plain-text identifier, the gate still accepts it because the loop reaches if ($relative -eq "scripts/verify-source-clean.ps1") { continue } before reading its content. This contradicts the newly stated no-whole-file-exemption invariant, and the fixture suite does not expose it because the scanner executable lives outside each temporary repository. Move the self-skip after the external-identifier check (skipping only the embedded policy-pattern checks) and add a fixture using this reserved path.
AGENTS.md reference: AGENTS.md:L172-L176
Useful? React with 👍 / 👎.
Rebuilt on current main after the interoperability-reference migration. Scope remains source-clean hardening only.
Changes:
System.Diagnostics.Processso Windows PowerShell stderr does not abort the test harness;No runtime, engine, Discovery, reporting, SCL, version or stable-release changes. Merge only after exact-head CI passes.