refactor(ui): express nullable binding path in signal-grid layout policy - #410
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pure contract correction for the existing WPF binding path.
GetBindingExpression(...)?....Path?.Pathis nullable, andstring.Equalshandles null safely. Annotate only the private layout helper parameter asstring?instead of pretending the captured path is statically non-null. This removes the CS8604 warning without introducing null-forgiving operators, branches, layout changes, or event-order changes.No IEC 61850 engine/runtime, Smart Discovery, RCB/DataSet reporting, SCL, release, or asset/provenance changes. Acceptance: exact-head full Windows build/regression and portable package checks; verify the specific CS8604 warning is absent, leaving unrelated nullable warnings for separate gated work.