refactor(formatting): avoid second legacy scalar extraction

[masarray]

Scope: one pure formatting subsystem — now based on merged #416 in main

#416 was merged as e7b43508fb3b2bf5fbda7be8ed8425da74bb9766. This PR's tree was reconstructed on that exact merged parent without changing any source blob. The diff against main is exactly two files: Services/Iec61850ValueFormatter.cs and tests/ARSAS.Tests/Iec61850ValueFormatterTests.cs.

Root cause and implementation

FormatReportProcessValue extracts a legacy Structure(...){stVal=...} or numeric metadata-qualified indexed scalar, then delegated to Format, which tried the same structure extraction again. A private FormatNormalizedValue now holds the original switch/Dbpos presentation, so both public entry points extract exactly once. This is display-only, with no protocol, report acquisition, static DataSet, RCB/GI, dynamic write/polling, public API, or persisted model change.

Regression coverage and consumers

Four added test cases cover Boolean and DPC structured report values, numeric indexed BCR-style presentation, and refusal to collapse a nonnumeric indexed structure. Existing generic/report operator vocabulary and timestamp tests remain. Report-driven monitor and FAT preview call FormatReportProcessValue; direct read/polling presentation uses generic Format; model/control TryNormalizeDbpos remains untouched. No performance gain or physical IED operation is claimed.

Integration provenance

• Parent: merged main e7b43508fb3b2bf5fbda7be8ed8425da74bb9766, a signed-off, 9/9 CI-green chore(maintenance): consolidate runtime boundary and deterministic CI #416 merge with eight exact source-blob matches.
• Current restacked head: c7edc91d1af814366af579e680acc5d37418923d, byte-identical formatter tree to the previous candidate. 9/9 exact-head CI successful: Build ARSAS (1,319 passed, 0 failed, 0 skipped), Merge Execution Guard (1,319 passed), Field Capture Build, SV evidence, and the five remaining Smart Discovery guards.
• Previous candidate Build ARSAS and Merge Execution Guard passed 1,319 tests, zero failures. These are historical evidence until CI completes on the current head.
• Contributor CLA agreement covering both chore(maintenance): consolidate runtime boundary and deterministic CI #416 and refactor(formatting): avoid second legacy scalar extraction #417 is explicitly recorded in this PR's Conversation. This refactoring commit still needs the contributor's own DCO sign-off; do not invent it or merge before it is present. The parent chore(maintenance): consolidate runtime boundary and deterministic CI #416 DCO is preserved.

No release, tag or production engine lock changes. Tracks #380.

Integration result — verified on actual main

• Contributor signed off the final refactor(formatting): avoid second legacy scalar extraction #417 commit at ef18befb760e0dae8be18894e57c60d8d6779823; CLA acceptance already recorded in its Conversation.
• GitHub rebase merged refactor(formatting): avoid second legacy scalar extraction #417 at 40355bca78341f02ecdc2c10199a1df062570897. Verified exact formatter tree and only two changed files.
• Post-merge push CI 2/2 success: Build ARSAS, 1,319 application tests passed, zero failed; Smart Discovery Post-Merge Production Verification, 988 engine + 1,319 application tests passed, zero failed.
• This is a source-only formatter refactor; no field IED validation or release/artifact promotion is claimed. The owner-requested future contribution policy update removing mandatory DCO is tracked separately in docs(contributing): retire mandatory DCO sign-off #418.

[masarray]

Focused consumer/impact audit for the two-file formatter refactor (against current #416 base):

• FormatReportProcessValue is called in Iec61850MonitorRuntime for report-driven display updates and in Services/IoTesting/NativeFatPrintPreviewSnapshot.cs for FAT preview; neither caller changes.
• Generic Format is used for direct-read value presentation in NativeIec61850Client and polling display in Iec61850MonitorRuntime; generic entry point retains first-pass extraction and its original formatting switch via the new private helper.
• TryNormalizeDbpos has direct model/control-state consumers in Models/SignalDefinition.cs and NativeIec61850Client.cs; that method and its implementation are untouched.
• Existing ReportProcessValueSafetyTests, timestamp display tests and report boolean display tests remain in the full test suite; new tests exercise Boolean and DPC structured report values, numeric indexed structures, and nonnumeric index refusal.
• No protocol decoder, report metadata, raw value, quality or timestamp data path is changed. This is a display-only internal call-graph simplification; no performance gain is claimed without measurement.

The PR remains stacked on #416 and CI is in progress; no merge/signoff claimed.

[masarray]

Pernyataan pribadi kontributor, diposting melalui ChatGPT berdasarkan izin eksplisit yang diberikan dalam percakapan:

Saya telah membaca dan menyetujui CLA ARSAS untuk kontribusi saya pada PR #416 dan #417. Saya memiliki hak yang diperlukan untuk menyumbangkan kontribusi tersebut, termasuk izin pemberi kerja jika diperlukan. Saya mengizinkan ChatGPT memposting pernyataan ini di kedua PR melalui akun GitHub saya.

[masarray]

#417 contributor handoff — CLA complete; only DCO sign-off for this new commit remains after final exact-head CI.

This draft now targets the real #416 merged main at e7b43508fb3b2bf5fbda7be8ed8425da74bb9766. Source tree/diff unchanged: two files, four added xUnit cases. Current refactor head: c7edc91d1af814366af579e680acc5d37418923d (currently not signed off).

For the contributor to sign with their own Git identity in their Windows clone:

git fetch origin
git switch --track origin/maintenance/value-formatter-single-normalization-20260926
git rev-parse HEAD
# Continue ONLY if the SHA equals c7edc91d1af814366af579e680acc5d37418923d
git config user.name
git config user.email
git commit --amend --no-edit --signoff
git log -1 --format=%B
git push --force-with-lease origin HEAD:maintenance/value-formatter-single-normalization-20260926

If the local branch already exists, switch to it and fast-forward to the current remote before amending; do not overwrite other local work. The Signed-off-by trailer is the contributor's own certification; ChatGPT has not inserted a substitute sign-off. After the SHA changes, verify one signed-off commit based on the merged main parent and run the 9 exact-head workflows again before merging. No release promotion or physical-device claim.