This repository was archived by the owner on Jan 21, 2025. It is now read-only.
SSE 0xa fix - #181
Merged
Merged
Conversation
Owner
|
@Tarik2142 thanks! can you please squash your commits into one and rebase on main ? I will merge just after. |
Tarik2142
force-pushed
the
sse_0xa_fix
branch
from
December 19, 2024 13:17
1ea1e02 to
eda8433
Compare
Revert "use my AsyncTCP fork" This reverts commit b956d15. use my AsyncTCP fork
mathieucarbou
force-pushed
the
sse_0xa_fix
branch
from
December 19, 2024 13:18
eda8433 to
8f44291
Compare
mathieucarbou
approved these changes
Dec 19, 2024
Owner
|
I am really surprised we didn't see that earlier! |
Author
|
It seems that the conversion problem occurs under some conditions, as some events run fine but some break. |
Owner
|
v3.4.5 is available! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes the conversion of
0xato10at the end of the message