Simplify logging of mavsdk_server output - #586
Closed
EricPedley wants to merge 2 commits into
Closed
Conversation
julianoes
reviewed
Apr 25, 2023
julianoes
left a comment
Collaborator
There was a problem hiding this comment.
What about making it an option?
Author
Yeah this is a good idea. I added another parameter to |
Collaborator
|
I think we should try to fix what was done in #370 (if it is indeed broken) instead 🤔 |
Collaborator
|
@EricPedley sorry, I didn't merge this but I hope what I did in #781 - released in 3.9.0 - works for you. If you could test it and report back whether it works for you, that would be fantastic. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
In #585 I described how logging output from the child process for
mavsdk_serverat only debug level hides useful errors from the user.Summary
This PR removes the logic for redirecting the subprocess stdout to the debugger and results in the mavsdk_server child process's stdout and stderr going straight to the main stdout/stderr.