Format Python code with ruff format by cclauss · Pull Request #790 · mavlink/MAVSDK-Python

cclauss · 2025-09-08T12:17:23Z

% ruff format # https://docs.astral.sh/ruff/formatter

 160 files changed, 30014 insertions(+), 32975 deletions(-)

Improve readability while removing 2,961 unnecessary lines.

ruff format should be added to code generation processes.

cclauss · 2025-09-08T14:11:30Z

          python3 -m pip install pycodestyle
          export PATH=$PATH:$HOME/.local/bin
-          pycodestyle examples/*
+          pycodestyle --max-line-length=88 examples/*


https://black.readthedocs.io/en/stable/the_black_code_style/current_style.html#labels-line-length

I'd go with 100.

The reason for 88 (not 100) was explained in that URL.

Interesting. I used to be strongly in favor of 80 but it does make it awkward when you want to have variable names that actually explain what they are instead of acronyms or abbreviations.

For the simple examples, I'm just going to leave it at the default pycodestyle 79 for now.

julianoes · 2025-09-08T21:08:12Z

          python3 -m pip install pycodestyle
          export PATH=$PATH:$HOME/.local/bin
-          pycodestyle examples/*
+          pycodestyle --max-line-length=88 examples/*


I'd go with 100.

julianoes · 2025-09-08T21:13:59Z

 class OrbitYawBehavior(Enum):
    """
-     Yaw behaviour during orbit flight.
+    Yaw behaviour during orbit flight.


Auto-generated!

Please read the commit message.

ruff format should be added to code generation processes.

Ok, feel free to do that. It's right here:

https://github.com/mavlink/MAVSDK-Python/blob/main/other/tools/run_protoc.sh

https://github.com/mavlink/MAVSDK-Python/pull/790/files#diff-57538fb4bd1ebb2ab1d9f8373d52380018bfa1f2c2f4ba25a71fed7ae99c528f

julianoes

Alright, let me get this in and add in the other PRs on top of it.

julianoes · 2025-09-09T22:07:26Z

          python3 -m pip install pycodestyle
          export PATH=$PATH:$HOME/.local/bin
-          pycodestyle examples/*
+          pycodestyle --max-line-length=88 examples/*


Interesting. I used to be strongly in favor of 80 but it does make it awkward when you want to have variable names that actually explain what they are instead of acronyms or abbreviations.

julianoes · 2025-09-09T22:08:38Z

@@ -96,4 +96,6 @@ function generate {

 echo "[+] Generating plugins from "
 generate
+python3 -m pip install --upgrade ruff
+ruff format


We should add the dependency to https://github.com/mavlink/MAVSDK-Python/blob/main/requirements-dev.txt. I'll add a commit.

julianoes · 2025-09-09T22:25:12Z

          python3 -m pip install pycodestyle
          export PATH=$PATH:$HOME/.local/bin
-          pycodestyle examples/*
+          pycodestyle --max-line-length=88 examples/*


For the simple examples, I'm just going to leave it at the default pycodestyle 79 for now.

julianoes · 2025-09-09T22:26:05Z

 class OrbitYawBehavior(Enum):
    """
-     Yaw behaviour during orbit flight.
+    Yaw behaviour during orbit flight.


cclauss force-pushed the ruff-format branch from 25c3514 to a77cb28 Compare September 8, 2025 14:09

cclauss commented Sep 8, 2025

View reviewed changes

julianoes requested changes Sep 8, 2025

View reviewed changes

cclauss mentioned this pull request Sep 9, 2025

Add pre-commit #792

Closed

pycodestyle --max-line-length=88 examples

3563880

cclauss force-pushed the ruff-format branch from a77cb28 to 3563880 Compare September 9, 2025 06:19

cclauss requested a review from julianoes September 9, 2025 06:20

julianoes added 3 commits September 10, 2025 10:21

Fixup ruff dependency, only on generated files

a1b465c

examples: style fixup

f2143dc

CI: relax max-line-length to 100

dcde9cb

julianoes force-pushed the ruff-format branch from d747918 to dcde9cb Compare September 9, 2025 22:29

julianoes approved these changes Sep 9, 2025

View reviewed changes

julianoes merged commit 9692e6e into mavlink:main Sep 9, 2025
9 checks passed

cclauss deleted the ruff-format branch September 10, 2025 04:32

Uh oh!

Conversation

cclauss commented Sep 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

julianoes left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

cclauss commented Sep 8, 2025 •

edited

Loading