Skip to content

Do not generate unnecessary map usage - #796

Closed
cclauss wants to merge 2 commits into
mavlink:mainfrom
cclauss:do-not-generate--unnecessary-map-usage
Closed

Do not generate unnecessary map usage#796
cclauss wants to merge 2 commits into
mavlink:mainfrom
cclauss:do-not-generate--unnecessary-map-usage

Conversation

@cclauss

@cclauss cclauss commented Sep 10, 2025

Copy link
Copy Markdown
Contributor

Fixes: #795

Rewrite in code generation instead of post-processing with ruff.

@julianoes julianoes left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, thanks!

@julianoes

Copy link
Copy Markdown
Collaborator

Can you run and commit the generation in a second commit?

@cclauss

cclauss commented Sep 10, 2025

Copy link
Copy Markdown
Contributor Author

It does not generate anything useful.

I expected that running the code generation would replicate all the changes in #795, but code generation did not make those changes.

@julianoes

Copy link
Copy Markdown
Collaborator

@cclauss so then what do you suggest I do with this PR? I'm really confused by all your PRs. Like I understand what you're trying to do but I don't understand why there are several PRs that all seem to do slightly a similar thing.

Yes, I haven't looked into it in detail, but I'm sorry I also don't have infinite time to look into this. I have to pay the bills after all :)

@cclauss

cclauss commented Sep 11, 2025

Copy link
Copy Markdown
Contributor Author

Understood. Closing.

@cclauss cclauss closed this Sep 11, 2025
@julianoes

Copy link
Copy Markdown
Collaborator

Sorry if we upset you, that wasn't the goal. Happy to merge future PRs if they work with the auto-generation, and I appreciate what you're doing.

@cclauss
cclauss deleted the do-not-generate--unnecessary-map-usage branch September 11, 2025 11:04
@cclauss

cclauss commented Sep 11, 2025

Copy link
Copy Markdown
Contributor Author

No problems…. All good here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants