fix: yarn.lock + pnpm-lock.yaml, version detection empty string, Node 18 CLI compat - #10
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes all 3 remaining test failures:
1. yarn/pnpm cache — lock file not found
Added minimal
yarn.lockandpnpm-lock.yamlto the repo.actions/setup-node@v4withcache: yarnlooks foryarn.lock; same for pnpm.2. npm version detection returning 'unknown'
ng version | grep | awkreturns empty string (not a non-zero exit) when output format doesn't match.Before:
|| echo unknown— only catches non-zero exitsAfter:
${CLI_VERSION:-unknown}— catches both non-zero and empty string3. Node 18 + latest Angular CLI fails
Angular CLI v19+ requires Node ≥ 20.19 or ≥ 22.12.
Node 18 test matrix entry now uses
version: '17.3.8'(last CLI version supporting Node 18).