fix: pnpm global bin PATH + pipefail-safe version detection - #11
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two final test failures:
1. pnpm global bin not on PATH
pnpm add -ginstalls to$(pnpm bin -g)(e.g.~/.local/share/pnpm) but that directory wasn't added to PATH.Fix: append
$(pnpm bin -g)to$GITHUB_PATHafter install — same pattern as yarn.2. version detection exits code 1 under pipefail
The shell runs with
-e -o pipefail.grepexits code 1 when it finds no match, which killed the whole step via pipefail.Fix: append
|| trueto the pipeline so it always exits 0; the${:-unknown}fallback then handles empty output.