Skip to content

feat (warning): Improve details of any invalid filters found - #440

Merged
mbrt merged 1 commit into
mbrt:masterfrom
jafin:feat/improve-filter-warning
Feb 2, 2026
Merged

mbrt merged 1 commit into
mbrt:masterfrom
jafin:feat/improve-filter-warning

Conversation

@jafin

@jafin jafin commented Jan 18, 2026 •

Copy link
Copy Markdown
Contributor

Improve details of any invalid filters found

Warning: Error getting one or more filters from Gmail: 1 error occurred:
* importing filter "ABC123XYZ": error message

Users will see:

Warning: Error getting one or more filters from Gmail: 1 error occurred:
* importing filter "ABC123XYZ" (criteria: from:someone@example.com subject:hello): error message

This makes it much easier to identify the problematic filter by showing its search criteria (from, to, subject, query) alongside the filter ID.

Reason

This came to be as I was having issues diagnosing why it was reporting i had invalid filters. I could not find it.
In the end it was a filter that replies with a template. It was considered "invalid" by gmailctl
Adding additional hints to which filter it is, allows faster tracing to the problematic filter.

 Warning: Error getting one or more filters from Gmail: 1 error occurred:
      * importing filter "ABC123XYZ": error message

  Users will see:

  Warning: Error getting one or more filters from Gmail: 1 error occurred:
      * importing filter "ABC123XYZ" (criteria: from:someone@example.com subject:hello): error message

  This makes it much easier to identify the problematic filter by showing its search criteria (from, to, subject, query) alongside the filter ID.
@codecov

codecov Bot commented Feb 2, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 55.55556% with 8 lines in your changes missing coverage. Please review.
✅ Project coverage is 37.56%. Comparing base (f2171ae) to head (6c95459).
⚠️ Report is 3 commits behind head on master.

Files with missing lines Patch % Lines
internal/engine/export/api/api_import.go 55.55% 4 Missing and 4 partials ⚠️

❌ Your patch status has failed because the patch coverage (55.55%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #440      +/-   ##
==========================================
+ Coverage   37.49%   37.56%   +0.07%     
==========================================
  Files          54       54              
  Lines        3646     3663      +17     
==========================================
+ Hits         1367     1376       +9     
- Misses       2192     2196       +4     
- Partials       87       91       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mbrt

mbrt commented Feb 2, 2026

Copy link
Copy Markdown
Owner

Thanks!

@mbrt
mbrt merged commit 41ef43b into mbrt:master Feb 2, 2026
4 of 5 checks passed
social4hyq pushed a commit to social4hyq/homebrew-core that referenced this pull request Sep 20, 2026
gmailctl 0.12.0

Created-by: HarmonybrewBot
Commit-by: HarmonybrewBot
Merged-by: HarmonybrewBot
Description: Created by `brew bump`

---

Created with `brew bump-formula-pr`.<details>
  <summary>release notes</summary>
  <pre>## What's Changed
### New features
* Add `--debug` flag to display Gmail search URL by @izidormatusov in mbrt/gmailctl#409
* Add context option for filter diffs by @kpengboy in mbrt/gmailctl#421
### Maintenance and bug fixing
* Update README.md - 'of' -> 'or' by @ChrisCarini in mbrt/gmailctl#369
* typo; `togheter` -> `together` by @ChrisCarini in mbrt/gmailctl#370
* fix typos by @RayBB in mbrt/gmailctl#380
* Move tmp files for edit command next to config file. by @mbrt in mbrt/gmailctl#386
* Skip quoting if args are already quoted. by @mbrt in mbrt/gmailctl#391
* Make init message less confusing by @mbrt in mbrt/gmailctl#394
* Configure Renovate by @renovate[bot] in mbrt/gmailctl#397
* Update min go version to 1.21 by @mbrt in mbrt/gmailctl#403
* fix missing close file in edit command by @testwill in mbrt/gmailctl#404
* Onboard to codecov by @mbrt in mbrt/gmailctl#406
* Bump golang.org/x/crypto from 0.29.0 to 0.31.0 by @dependabot[bot] in mbrt/gmailctl#418
* Fix initialization of cfgDir by @kpengboy in mbrt/gmailctl#422
* Allowing to specify a port for OAuth server by @kipelovets in mbrt/gmailctl#430
* Colorize diff output by @kpengboy in mbrt/gmailctl#423
* Fix code scanning alert: Workflow does not contain permissions by @mbrt in mbrt/gmailctl#439
* feat (warning): Improve details of any invalid filters found by @jafin in mbrt/gmailctl#440
* Update README with Windows editor configuration by @jafin in mbrt/gmailctl#441
* task(workflow): Replace matrix build with GoReleaser for releases by @gene1wood in mbrt/gmailctl#450
* Add category PURCHASES by @mbrt in mbrt/gmailctl#453

## New Contributors
* @ChrisCarini made their first contribution in mbrt/gmailctl#369
* @RayBB made their first contribution in mbrt/gmailctl#380
* @renovate[bot] made their first contribution in mbrt/gmailctl#397
* @testwill made their first contribution in mbrt/gmailctl#404
* @izidormatusov made their first contribution in mbrt/gmailctl#409
* @kpengboy made their first contribution in mbrt/gmailctl#422
* @kipelovets made their first contribution in mbrt/gmailctl#430
* @jafin made their first contribution in mbrt/gmailctl#440
* @gene1wood made their first contribution in mbrt/gmailctl#450

**Full Changelog**: https://github.com/mbrt/gmailctl/compare/v0.10.7...v0.12.0</pre>
  <p>View the full release notes at <a href="https://github.com/mbrt/gmailctl/releases/tag/v0.12.0">https://github.com/mbrt/gmailctl/releases/tag/v0.12.0</a>.</p>
</details>
<hr>

See merge request: Harmonybrew/homebrew-core!3726
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants