Skip to content

Fprettify fixes for several files - #291

Merged
anilyil merged 56 commits into
mdolab:mainfrom
ArshSaja:fprettify_fix
Jun 27, 2023
Merged

Fprettify fixes for several files#291
anilyil merged 56 commits into
mdolab:mainfrom
ArshSaja:fprettify_fix

Conversation

@ArshSaja

Copy link
Copy Markdown
Contributor

Purpose

This PR is coming from #238. It includes formatting fixes for Fortran files.

Expected time until merged

Type of change

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (non-backwards-compatible fix or feature)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Documentation update
  • Maintenance update
  • Other (please describe)

Testing

Checklist

  • I have run flake8 and black to make sure the Python code adheres to PEP-8 and is consistently formatted
  • I have formatted the Fortran code with fprettify or C/C++ code with clang-format as applicable
  • I have run unit and regression tests which pass locally with my changes
  • I have added new tests that prove my fix is effective or that my feature works
  • I have added necessary documentation

@ArshSaja
ArshSaja requested a review from a team as a code owner June 26, 2023 15:47
@ArshSaja
ArshSaja requested review from anilyil and marcomangano June 26, 2023 15:47
@ArshSaja
ArshSaja requested a review from sseraj June 26, 2023 16:04
@codecov

codecov Bot commented Jun 26, 2023

Copy link
Copy Markdown

Codecov Report

Merging #291 (34e5fd6) into main (f8943e6) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #291   +/-   ##
=======================================
  Coverage   42.51%   42.51%           
=======================================
  Files          13       13           
  Lines        3952     3952           
=======================================
  Hits         1680     1680           
  Misses       2272     2272           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@sseraj sseraj left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. There are no more warnings when running fprettify.

@anilyil
anilyil merged commit 476a98e into mdolab:main Jun 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants