This repository was archived by the owner on Jan 20, 2025. It is now read-only.
rename HTTP_* to avoid redeclaration errors with ESP8266WebServer.h - #215
Closed
drnic wants to merge 1 commit into
Closed
rename HTTP_* to avoid redeclaration errors with ESP8266WebServer.h#215drnic wants to merge 1 commit into
drnic wants to merge 1 commit into
Conversation
Author
|
This PR may be a breaking change for clients such as https://bitbucket.org/xoseperez/fauxmoesp/pull-requests/3/support-for-async_http_-rename-in/diff |
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was trying to combine FauxMo which uses this library, and https://github.com/tzapu/WiFiManager
which uses ESP8266WebServer.h. Unfortunately there is a clash over the HTTP_* enums.
This PR renames them to allow the two headers (this and ESP8266WebServer.h) to be
used in the same project.