Update getUniqueKey to use fallback for undefined IDs - #22
Open
Avi-ADAM wants to merge 1 commit into
Open
Conversation
function getUniqueKey(row) {
return uniqueRowIds.find(x => x.row.id === row.id)?.id;
}
uniqueRowIds and the rendered gridData are populated by two separate $effects that both react to the filtered data changing. Clicking a filter button changes filteredActs, which can update gridData (via the grid derived) and uniqueRowIds in different reactive ticks. In that transient mismatch, some rows in gridData have no matching entry in the (temporarily stale) uniqueRowIds, so getUniqueKey returns undefined for more than one row → Svelte's each_key_duplicate error.
Fix
the key always falls back to the row's own id (which is always defined and unique in your data) instead of failing when the lookup race happens:
- return uniqueRowIds.find(x => x.row.id === row.id)?.id;
+ return uniqueRowIds.find(x => x.row.id === row.id)?.id ?? row?.id ?? row;
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
function getUniqueKey(row) {
return uniqueRowIds.find(x => x.row.id === row.id)?.id;
}
uniqueRowIds and the rendered gridData are populated by two separate $effects that both react to the filtered data changing. Clicking a filter button changes filteredActs, which can update gridData (via the grid derived) and uniqueRowIds in different reactive ticks. In that transient mismatch, some rows in gridData have no matching entry in the (temporarily stale) uniqueRowIds, so getUniqueKey returns undefined for more than one row → Svelte's each_key_duplicate error.
Fix
the key always falls back to the row's own id (which is always defined and unique in your data) instead of failing when the lookup race happens: