Summary
disk-hygiene:setup check probes prerequisites but never exercises the guard end-to-end, so it
reports all-PASS while the engine is actually dead — including the exact failure this session
hit (#376) and the python-launch risk (see the bare-python hook issue).
Details
So a Windows/macOS/Linux user whose skill-frontmatter hook doesn't get plugin env (or whose python
doesn't resolve) gets a green setup:check while every guarded scan dead-ends.
Suggested fix
Add end-to-end probes to check:
- Run the guard against a synthetic bare-python scan denial and assert the data-root disclosure is
present (i.e. CLAUDE_PLUGIN_DATA reached the hook process).
- Assert the hook's configured interpreter resolves to Python 3.11+.
- Report a clear FAIL with remediation when either is missing, instead of a misleading PASS.
Severity
MEDIUM — the diagnostic tool fails to diagnose the plugin's actual, most common failure mode.
Related: #376, and the bare-python hook-launch issue.
Summary
disk-hygiene:setup checkprobes prerequisites but never exercises the guard end-to-end, so itreports all-PASS while the engine is actually dead — including the exact failure this session
hit (#376) and the
python-launch risk (see the bare-pythonhook issue).Details
skills/setup/SKILL.md:20-46probes Python 3.11+, conditional Git, the OS-family lane, and thedisk_hygiene_enabledtoggle.CLAUDE_PLUGIN_DATA(the disk-hygiene: skill-frontmatter guard reads CLAUDE_PLUGIN_DATA from env but never receives it -> engine lane fails closed on all platforms #376failure), and never confirms the hook's own interpreter (
command: "python") resolves.So a Windows/macOS/Linux user whose skill-frontmatter hook doesn't get plugin env (or whose
pythondoesn't resolve) gets a green
setup:checkwhile every guarded scan dead-ends.Suggested fix
Add end-to-end probes to
check:present (i.e.
CLAUDE_PLUGIN_DATAreached the hook process).Severity
MEDIUM — the diagnostic tool fails to diagnose the plugin's actual, most common failure mode.
Related: #376, and the bare-
pythonhook-launch issue.