You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Addresses the 8 Codex publish-review findings deferred from the work-items v2 republish, applied to the published plugin skill (plugins/work-items). The medley core PR mirrors these behaviorally so both stay aligned modulo the publish de-couple.
Findings addressed
add default body skeleton restored — Context / Proposed work / Acceptance criteria / References / Metadata.
add --recurring creates the schedule file with an {"items": []} skeleton (ask-first) when it does not exist yet.
add --agent-ready appends the agent-ready meta label for autonomous pickup.
needs-human added to the Meta group (label-taxonomy + SKILL).
Seam invocations project-rooted (${CLAUDE_PROJECT_DIR:-$(git rev-parse --show-toplevel)}) so they work from a subdirectory.
done --pr no longer closes an item whose PR is still unmerged.
due matches open recurring items on the full [Maintenance] {title}, not the bare prefix.
recheck checklist aligned to the recheck action.
Refs melodic-software/medley#1460
Note
Low Risk
Documentation-only changes to agent skill markdown; behavior shifts are procedural guidance for agents, not executable product code.
Overview
Addresses eight deferred Codex publish-review findings in the published plugins/work-items skill (agent instructions only—no tracker runtime code).
add restores the default item body (Context, Proposed work, Acceptance criteria, References, Metadata), applies the agent-ready meta label when --agent-ready is set, and tightens --recurring: bootstrap .github/recurring-schedule.json (ask-first) before creating [Maintenance] items that due/recheck cannot reconcile.
Taxonomy documents needs-human in the Meta group so HITL slices align with list-frontier --autonomous exclusion (already described in decompose).
Seam snippets across actions use ${CLAUDE_PROJECT_DIR:-$(git rev-parse --show-toplevel)} so work-item-tracker.sh works from subdirectories; recurring jq examples use explicit if [[ -f "$SCHEDULE" ]] guards.
done --pr no longer closes an item when the named PR is still unmerged and will auto-close this issue via Closes #N (or respects per-issue opt-outs); closing keywords are evaluated for the target issue, not another issue on the same PR.
due (and matching guidance in work) requires exact[Maintenance] {schedule title} matches when cross-referencing open recurring items—no bare [Maintenance] prefix or substring matches.
recheck checklist in templates/checklist.md matches the real recheck flow (schedule lookup, date updates, close associated maintenance item).
Reviewed by Cursor Bugbot for commit 251051a. Bugbot is set up for automated code reviews on this repo. Configure here.
Resolves the 8 findings deferred from the work-items v2 republish
(claude-code-plugins#121), applied to the published plugin skill (the medley
core PR mirrors these behaviorally so both stay aligned modulo the publish
de-couple):
1. add: restore the richer default body skeleton (Context / Proposed work /
Acceptance criteria / References / Metadata).
2. add --recurring: create the schedule file with an {"items": []} skeleton
(ask-first) when it does not exist yet.
3. add --agent-ready: append the agent-ready meta label for autonomous pickup.
4. taxonomy: add needs-human to the Meta group (label-taxonomy + SKILL).
5. seam invocations: project-root the tracker path
(${CLAUDE_PROJECT_DIR:-$(git rev-parse --show-toplevel)}) so they work
from a subdirectory.
6. done --pr: do not close an item whose PR is still unmerged.
7. due: match open recurring items on the full [Maintenance] {title}.
8. checklist: align the recheck section to the recheck action.
Refs melodic-software/medley#1460
The reason will be displayed to describe this comment to others. Learn more.
Stale comment
Risk: low. Not approving because Cursor Bugbot did not complete successfully (check skipped due to usage limit). Human review is needed before merge; no reviewers were assigned because the sole repo contributor is the PR author.
Sent by Cursor Approval Agent: Pull Request Router and Approver
The reason will be displayed to describe this comment to others. Learn more.
Stale comment
Risk: low. Not approving because Cursor Bugbot did not complete successfully (check skipped due to usage limit). Human review is needed before merge; no reviewers were assigned because the sole repo contributor is the PR author.
Sent by Cursor Approval Agent: Pull Request Router and Approver
…ering + schedule guards)
Mirrors the medley core fixes so both stay aligned:
- add/decompose: order the create-item snippet so the Write-to-$BODY_FILE step
is shown after mktemp and before create-item.
- audit/due/recheck/work: convert '[[ -f $SCHEDULE ]] && jq' guards to
'if [[ -f ]]; then jq; fi' so an absent schedule file returns exit 0.
Refs melodic-software/medley#1460
The reason will be displayed to describe this comment to others. Learn more.
Stale comment
Risk: low. Not approving because Cursor Bugbot did not complete successfully (check skipped). Human review is needed before merge; no reviewers were assigned because the sole repo contributor is the PR author.
Sent by Cursor Approval Agent: Pull Request Router and Approver
All 8 stated findings are addressed correctly. The seam-path fix (finding 5) is applied consistently across all 6 action files. The PR is low-risk markdown-only changes. I confirmed the two existing Codex P2 findings and found a third gap the Codex review missed.
But recheck.md Step 2 says "past or today", and Step 3 is explicit:
If `next_due <= today`: set `next_due` to today + cadence days
A recurring item due today would have its checklist tell the agent not to advance next_due, leaving it at today. The due/work actions would then continue to surface it as overdue, and the next recheck run could cause a double-advance or confusion. The fix is one word: change "past due" → "past due or today". Fix this →
Step 4 defers closure and says "run the keyword step below first so Closes #<N> is on the PR body." Step 5 then says:
if the (unmerged) PR body carries neither a closing keyword nor an opt-out marker, prepend Closes #<N>
The gap: if the PR already closes a different issue (Closes #OTHER) or has any opt-out marker (Refs #N, No related issue:), Step 5 skips prepending the keyword for #<N>. Step 4 still tells the user "will auto-close when #{pr} merges" — which is false. The item stays open after the PR merges.
Step 4 should gate on whether the keyword was actually placed (or already present for this item), falling back to a direct close when the keyword cannot be guaranteed. Fix this →
3. checklist.md:7,17,24 — Seam paths not project-rooted (new finding)
Finding 5 applied project-rooted seam paths to all 6 action files, but the checklist template still uses bare relative paths in its snippets:
Line 7: `tools/work-item-tracker/work-item-tracker.sh reclaim "<id>"`
Line 17: `tools/work-item-tracker/work-item-tracker.sh create-item ...`
Line 24: `tools/work-item-tracker/work-item-tracker.sh reclaim "<id>"`
Line 25: `tools/work-item-tracker/work-item-tracker.sh claim "<id>"`
An agent following the checklist from a subdirectory will hit the same path-resolution failure that finding 5 fixed in the action files. The checklist snippets should use the same "${CLAUDE_PROJECT_DIR:-$(git rev-parse --show-toplevel)}/tools/..." form, or the checklist note should say these are illustrative and the action file's rooted form takes precedence. Fix this →
Minor observations
add.md comment reordering (lines 73–77): The comment explaining the Write-tool-before-create-item sequence now precedes BODY_FILE=$(mktemp), which puts the instruction before the variable exists. The meaning is clear, but placing the comment after mktemp (as the old version did) better preserves the "read-and-understand-the-variable-then-its-usage" flow. Not a correctness issue.
start.md — second claim call (line 28): Step 2 uses "${CLAUDE_PROJECT_DIR:-...}" but without the TRACKER= variable set in Step 1 — inconsistency with Step 1's pattern. Not a real bug since both forms expand identically, but slight style drift.
Verdict
The core behavioral fixes (1–8) are all implemented correctly. The two Codex P2 findings are confirmed real. The third gap (checklist bare paths) is a missed application of finding 5. All three are small, targeted fixes — this PR is otherwise clean and ready to merge modulo those.
…recurring)
- done: the unmerged --pr path now branches on THIS item's closing keyword —
respects a deliberate opt-out (Refs #N / No related issue:) instead of
falsely claiming auto-close, and never counts a different issue's keyword.
- checklist(recheck): advance next_due when due today OR past (next_due <= today),
matching the recheck action (was 'only when past due').
- add(--recurring): resolve the schedule bootstrap BEFORE create-item so a
declined/failed schedule doesn't strand an unreconcilable [Maintenance] item.
Refs melodic-software/medley#1460
The reason will be displayed to describe this comment to others. Learn more.
Risk: low. Not approving because Cursor Bugbot did not complete successfully (check skipped). Human review is needed before merge; no reviewers were assigned because the sole repo contributor is the PR author.
Sent by Cursor Approval Agent: Pull Request Router and Approver
Read diff at HEAD 251051a to verify prior findings are resolved
Check for new issues introduced in latest commits
Post final review summary
Summary
The two Codex P2 findings and the add --recurring schedule-bootstrap race confirmed in round 1 are all properly fixed in 251051a. One finding from round 1 remains unaddressed: the checklist template still carries bare relative seam paths.
Findings fixed in 251051a
Finding
Status
Codex P2 — checklist.md:40next_due boundary wrong ("past due" → "past due or today")
✅ Fixed — now reads advance next_due when it is due today or past due (next_due <= today)
✅ Fixed — Step 4 now branches on THIS item's #<N> keyword specifically; a different issue's closing keyword no longer counts, and a deliberate opt-out for #<N> no longer falsely claims auto-close
add.md schedule bootstrap order — [Maintenance] item could be created before the user confirms the schedule
✅ Fixed — Step 5 now says to resolve the bootstrap FIRST; on decline/failure the item is created non-recurring or aborted
The done.md fix is well-structured. Step 5's keyword prepend check is now correctly keyed to #<N> (not any closing keyword), and Step 4's branching correctly scopes the opt-out check to this item — the logic is internally consistent.
Remaining gap — checklist.md bare seam paths (finding #3 from round 1)
Round 1 noted that the checklist template's seam snippets were not updated when finding 5 applied project-rooted paths to all 6 action files. 251051a only touched line 40 (the next_due boundary). Lines 7, 17, 24, and 25 still carry bare relative paths:
Line 7: `tools/work-item-tracker/work-item-tracker.sh reclaim "<id>"`
Line 17: `tools/work-item-tracker/work-item-tracker.sh create-item ...`
Line 24: `tools/work-item-tracker/work-item-tracker.sh reclaim "<id>"`
Line 25: `tools/work-item-tracker/work-item-tracker.sh claim "<id>"`
An agent following the checklist from a subdirectory hits the same resolution failure that finding 5 fixed in the action files. The fix is to update these four lines to use "${CLAUDE_PROJECT_DIR:-$(git rev-parse --show-toplevel)}/tools/work-item-tracker/work-item-tracker.sh". Fix this →
Verdict
The core behavioral fixes are all correct and well-implemented. The two Codex P2s are resolved. The only outstanding item is the four bare paths in the checklist template (a missed application of finding 5). Everything else is clean — the PR is ready to merge once those four lines are updated.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses the 8 Codex publish-review findings deferred from the work-items v2 republish, applied to the published plugin skill (
plugins/work-items). The medley core PR mirrors these behaviorally so both stay aligned modulo the publish de-couple.Findings addressed
adddefault body skeleton restored — Context / Proposed work / Acceptance criteria / References / Metadata.add --recurringcreates the schedule file with an{"items": []}skeleton (ask-first) when it does not exist yet.add --agent-readyappends theagent-readymeta label for autonomous pickup.needs-humanadded to the Meta group (label-taxonomy + SKILL).${CLAUDE_PROJECT_DIR:-$(git rev-parse --show-toplevel)}) so they work from a subdirectory.done --prno longer closes an item whose PR is still unmerged.duematches open recurring items on the full[Maintenance] {title}, not the bare prefix.recheckchecklist aligned to the recheck action.Refs melodic-software/medley#1460
Note
Low Risk
Documentation-only changes to agent skill markdown; behavior shifts are procedural guidance for agents, not executable product code.
Overview
Addresses eight deferred Codex publish-review findings in the published
plugins/work-itemsskill (agent instructions only—no tracker runtime code).addrestores the default item body (Context, Proposed work, Acceptance criteria, References, Metadata), applies theagent-readymeta label when--agent-readyis set, and tightens--recurring: bootstrap.github/recurring-schedule.json(ask-first) before creating[Maintenance]items thatdue/recheckcannot reconcile.Taxonomy documents
needs-humanin the Meta group so HITL slices align withlist-frontier --autonomousexclusion (already described indecompose).Seam snippets across actions use
${CLAUDE_PROJECT_DIR:-$(git rev-parse --show-toplevel)}sowork-item-tracker.shworks from subdirectories; recurringjqexamples use explicitif [[ -f "$SCHEDULE" ]]guards.done --prno longer closes an item when the named PR is still unmerged and will auto-close this issue viaCloses #N(or respects per-issue opt-outs); closing keywords are evaluated for the target issue, not another issue on the same PR.due(and matching guidance inwork) requires exact[Maintenance] {schedule title}matches when cross-referencing open recurring items—no bare[Maintenance]prefix or substring matches.recheckchecklist intemplates/checklist.mdmatches the real recheck flow (schedule lookup, date updates, close associated maintenance item).Reviewed by Cursor Bugbot for commit 251051a. Bugbot is set up for automated code reviews on this repo. Configure here.